-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preset and field for sport=table_football #485
Conversation
I've read the wiki article. The tag is meant to be added as a field to amenities like pubs etc. to indicate that it has a table soccer table (the same being possible for darts, 9pin, billiard or whatever else can be played at that pub)
So what you would want to add is a |
Hi @westnordost thanks for your comments. Note that my PR addess this issue OsmTravel/OsmGo#108:
In this issue, @maroneze report table soccer directly in parks as a POI (so out of amenities, pub, etc). So @maroneze will more than probably map then directly as a node on the map. Please let me know your point of view @westnordost 👍 |
I had never seen it either (and I thought it unwise due to rain), but apparently that's a thing in some French towns (I've seen at least 3 in nearby towns). I didn't think of taking a photo (I will try to do it to submit it to the OSM wiki eventually), but if you google "babyfoot table parc" in Google Images ('babyfoot' is the French term for table soccer), you can hopefully see a few examples. Some companies sell them directly to town councils who want to refurbish parks. |
Table soccer tables can of course also be mapped if they are indoors, like other kinds of pitches too. "indoor=yes" may be added in these cases, example https://www.openstreetmap.org/node/9551800192 |
Currently, the tag is used surprisingly rarely: of the ~300 features which have the tag, around half to two thirds seem to be amenity features like pubs (which would benefit from an added These raw usage numbers wouldn't currently warrant the inclusion as a preset/field, but I would also assume that table soccer tables are quite significantly more common in real life compared what is currently mapped. Therefore, I would not object adding this tag as a preset and/or field. For a field, it would probably be needed to use a |
Hi @tyrasd, please let me know how I should amend my PR 👍 |
Could you please, in addition to the already created new preset, also add a new field called |
TY @tyrasd, i just pushed the requested changes. Can you please review them 👍 |
Looks good to me, thanks! 👍 I only changed the preset's name to |
Hi @tyrasd I'm not a native english speaker, so I usually trust wikipedia to translate from french.
|
I think that this should be named For example, Amazon in the US refers to this game as 'foosball' while Amazon.co.uk calls this game 'table football': |
So we just revert to "Table football" and we can merge? |
Merged with "Foosball Table" as the preset's name and field value. PS: I just noticed that there is no icon for the preset, but it's also not easy to find something that fits. There isn't really anything on maki, temaki and not even fontawesome when searching in fontawesome's collection). Svgrepo (see ideditor/schema-builder#60) would have one, but it's too detailed for the size we would display it at. |
Hi, here is a proposition for https://wiki.openstreetmap.org/wiki/Tag:sport=table_soccer
But DO NOT MERGE IT yet. Cause I created it as a preset of leisure=pitch BUT the wiki do not say it should be "combined" with leisure=pitch. It seems this tag sport=soccer can be "alone" on a node without any other tag.
Can you please tell me how we should add it in the id-tagging-schema?