Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suggest capacity for amenity=parking_space #278

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

jdhoek
Copy link
Contributor

@jdhoek jdhoek commented Nov 24, 2021

With amenity=parking_space it is possible to map separate parking spaces in a parking area. It can be used with capacity in case the space is used for more than one vehicle, but this is an exception. By default, capacity=1 is implied, and many mappers omit the capacity tag when its value would be 1, only using it when it deviates from the default.

By suggesting adding capacity=1 to parking spaces lacking the capacity tag, the editor stimulates adding a tag which is not needed in the vast majority of the cases, and novice users make edits containing many of these changes where they are not needed. I find that this suggestion is causing more noise than useful contributions.


We've seen this a couple of times in the Netherlands, were well meaning new mappers look to the issues-tab in ID to look for problems to fix, but adding capacity=1 to a parking lot containing hundreds of parking spaces is not very useful.

With `amenity=parking_space` it is possible to map separate parking
spaces in a parking area. It can be used with `capacity` in case the
space is used for more than one vehicle, but this is an exception. By
default, `capacity=1` is implied, and many mappers omit the capacity tag
when its value would be `1`, only using it when it deviates from the
default.

By suggesting adding `capacity=1` to parking spaces lacking the capacity
tag, the editor stimulates adding a tag which is not needed in the vast
majority of the cases, and novice users make edits containing many
of these changes where they are not needed. I find that this sugggestion
is causing more noise than useful contributions.
@jdhoek
Copy link
Contributor Author

jdhoek commented Nov 24, 2021

Here you can see how this particular warning drowns out other warnings:

Screenshot from 2021-11-24 19-10-41

This is common with parking spaces, because even a small parking lot can contain dozens of them, and a large one hundreds.

Suggesting the addition of capacity to amenity=parking is much more useful, and I'm actually surprised that there is no warning for that.

@1ec5
Copy link
Contributor

1ec5 commented Nov 24, 2021

Suggesting the addition of capacity to amenity=parking is much more useful, and I'm actually surprised that there is no warning for that.

capacity=1 was likely added here as low-hanging fruit. iD’s validator can only warn when both the key and value are known; it doesn’t have a straightforward way to warn about a key being missing and have the user fill out the value, though that would be an interesting feature enhancement.

@bhousel
Copy link
Member

bhousel commented Nov 24, 2021

Agree with this - it should have been done this way originally.

@bhousel bhousel merged commit 7986680 into openstreetmap:main Nov 24, 2021
@tyrasd tyrasd mentioned this pull request Jan 6, 2022
@tyrasd tyrasd added the bug Something isn't working label Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants