Add Population Date and Population Source fields #261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Population Date and Population Source fields that only show up if Population is already tagged on the feature. Unlike the Source field, Population Source completes the most popular values on taginfo instead of a fixed set of known values, since there are so many possible values depending on the region.
Ideally,
census:population
would be deprecated in favor of a combination ofpopulation
andpopulation:date
: openstreetmap/iD#6678. However, I don’t think the deprecated.json format supports splitting a tag value across two keys (which is one of the problems withcensus:population
in the first place).Fixes openstreetmap/iD#6672 except for the validation ideas in there. In my opinion, it would be worth visually grouping the fields first to set a user expectation that the fields are related: openstreetmap/iD#8104.