Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translatable tunnel types #251

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Add translatable tunnel types #251

merged 2 commits into from
Oct 14, 2022

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Oct 19, 2021

Added human-readable, translatable display names for some documented values of tunnel=*.

@tyrasd
Copy link
Member

tyrasd commented Dec 13, 2021

Should we also add these strings to https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/tunnel.json? As far as I can see, the tunnel_combo field is only used in the man_made=tunnel preset, which has relatively little usage I would say.

@tyrasd tyrasd added the enhancement New feature or request label Dec 13, 2021
@tyrasd tyrasd force-pushed the main branch 2 times, most recently from 9d3204d to 49f529e Compare June 22, 2022 16:19
@tyrasd tyrasd added new-value and removed enhancement New feature or request labels Oct 14, 2022
@tyrasd tyrasd merged commit 51d64f2 into openstreetmap:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-value
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @tyrasd