Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding maxheight to parking garage entrance/exit #232

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

cicku
Copy link
Contributor

@cicku cicku commented Sep 6, 2021

A lot of garage entrances/exits have height restriction. Tagging the service road towards the entrance is not very accurate, so I would like to propose this change.

@tyrasd
Copy link
Member

tyrasd commented Dec 13, 2021

Is there consensus for mapping height restrictions on the entrances of parking facilities? I don't see it mentioned on the wiki.

FWIW, about 7% of amenity=parking_entrance objects have also a maxheight tag (source: taginfo).

@tyrasd tyrasd added the waitfor-consensus there seems to be no clear consensus on this in the osm communtiy; this has to wait label Dec 13, 2021
@andrewharvey
Copy link
Contributor

I think given 7% already have the tag, that's good enough consensus. I can't see why it would be an issue. I've added it to the wiki as an optional tag combination.

@tyrasd
Copy link
Member

tyrasd commented Dec 15, 2021

I agree that this looks like something the proposal simply forgot to include.1 But I still think that this repository is not the right place to fix a "mistake" in a tagging proposal. Also, the definition of the maxheight tag in the wiki also kind of contradicts the proposed usage (highlight by me):

The tag maxheight=* specifies the maximum height limit for vehicles using the way to which the tag is added

Footnotes

  1. Or, perhaps the intended way to tag such a height restriction would be to combine the parking entrance with a nearby placed barrier=height_restrictor node? I don't know.

@cicku
Copy link
Contributor Author

cicku commented Dec 15, 2021

Using the way?

Time to update the wiki.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of this tagging combination has increased to almost 10% by now.

Although it would have been better to have a more explicit clarification / discussion about this (if anything, this PR would have been able to get merged much quicker!), I think the continued usage of this tag combination and its documentation on the OSM wiki sufficiently show that this tagging can be considered to be established.

@tyrasd tyrasd removed the waitfor-consensus there seems to be no clear consensus on this in the osm communtiy; this has to wait label Aug 8, 2024
@tyrasd tyrasd merged commit 790f6d9 into openstreetmap:main Aug 8, 2024
@tyrasd
Copy link
Member

tyrasd commented Aug 8, 2024

Time to update the wiki.

@cicku are you still interested in fixing this mistake on the wiki? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants