Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields to building=construction preset #171

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Add fields to building=construction preset #171

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b510a8f
Add fields to building=construction preset
Pengor May 7, 2021
5dd5f7b
Fixed commas
Pengor May 7, 2021
b1e14c5
Merge branch 'openstreetmap:main' into main
Pengor Aug 5, 2021
d256549
Add "construction" field
Pengor Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions data/presets/building/construction.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
{
"icon": "maki-building",
"fields": [
"name",
Pengor marked this conversation as resolved.
Show resolved Hide resolved
"address",
"opening_date",
"check_date"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less important, but I am curious in hearing opinions if it would makes sense to also add default building fields: building/levels and height here. I suppose the usage could be unclear, given that it could be interpreted as either planned or current. I didn't manage to find any docs on this, but personally I think it would be beneficial to use these in similar context as check_date (to update them during the construction) in order to track the current state and progress.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me if people would use it, I rarely know the values to populate those tags but I imagine there are those who do.

],
"geometry": [
"area"
],
Expand Down