Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese Fast Food preset #1280

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

arch0345
Copy link
Contributor

@arch0345 arch0345 commented Jul 9, 2024

Description, Motivation & Context

This PR adds a preset for amenity=fast_food + cuisine=chinese. As mentioned in the issue linked below, chinese fast food establishments are quite common in the US.

Also adds dim sum as a term for the Chinese Restaurant preset

Related issues

Closes #1277

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:
image
According to Taginfo, there are currently ~10K features with this tag combination. Around 20% of all features tagged with cuisine=chinese use amenity=fast_food as its top level tag.

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1280--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n3781511101&map=20.00/33.68701/-117.85569

image

Search

image

image

Copy link

github-actions bot commented Jul 9, 2024

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator

tordans commented Jul 9, 2024

This is for #1277, right? Please add a "closes X" to you description so a later merge will close that issue as well.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed "cafe" from the term of the new preset (I assume a copy-paste mistake). Otherwise it looks good to me. 👍

PS: The terms of the "Chinese Restaurant" preset has like many of the specific restaurant presets duplicates of lots of terms of the main generic restaurant preset. That does not make much sense IMO. But that's unrelated to this PR and should be fixed independently.

@tyrasd tyrasd merged commit 4535fb7 into openstreetmap:main Jul 22, 2024
5 checks passed
@1ec5
Copy link
Contributor

1ec5 commented Jul 23, 2024

Also adds dim sum as a term for the Chinese Restaurant preset

By the way, Chinese dim sum is also a common “food to go” fast food specialty in some regions. Not sure if it would be confusing to make it a term for the fast food preset too.

@arch0345
Copy link
Contributor Author

By the way, Chinese dim sum is also a common “food to go” fast food specialty in some regions. Not sure if it would be confusing to make it a term for the fast food preset too.

Yeah, I've encountered some of these places in SoCal. This PR also added dim sum as a term for the fast food preset

@arch0345 arch0345 deleted the chinese-fast-food branch July 27, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Chinese Fast Food
4 participants