Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove matchScore=1.1 from Kitchen Garden #1253

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Jun 6, 2024

This is a follow up to #1135 (comment), it seems like matchScore is not required here and is causing unexpected behaviour (see that comment for details)

Copy link

github-actions bot commented Jun 6, 2024

🍱 You can preview the tagging presets of this pull request here.

@k-yle
Copy link
Collaborator Author

k-yle commented Jun 6, 2024

the preview confirms that this works, and you can still select a specific garden:type. If you select a value with a dedicated preset, then that preset takes over

@tordans tordans merged commit 7252394 into openstreetmap:main Jun 6, 2024
5 checks passed
@tordans
Copy link
Collaborator

tordans commented Jun 6, 2024

Thanks for the screenshots, I agree with this.

A follow up could be to add translated strings to the garten type field so they have more of a match between them.

@tordans
Copy link
Collaborator

tordans commented Jun 6, 2024

Mh… merging this causes errors at https://github.com/openstreetmap/id-tagging-schema/actions/runs/9403688023

Habe to look into this later.

@k-yle k-yle deleted the kh/kitchen-garden branch June 6, 2024 22:33
@k-yle
Copy link
Collaborator Author

k-yle commented Jun 6, 2024

Regarding the GitHub Actions issue, I've opened #1254

@tyrasd tyrasd added the bug Something isn't working label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants