-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create preset for footwear_decontamination #1235
Conversation
🍱 You can preview the tagging presets of this pull request here. |
I think starting with presets locally is better. It makes it easier to have a good UX when less relevant options are not present for other countries (and easy to fix later). I would rather think we should limit the other preset to countries that are relevant. |
@k-yle looking at our new draft docs, I wonder if this is merge ready or fits our criteria already. A few thoughts…
|
Maybe |
I've opened rapideditor/temaki#93 to create a dedicated icon, so I suppose this PR needs
waitfor-icon
It is low, but it's higher than Currently, the fallback preset is |
Co-authored-by: Tobias <t@tobiasjordans.de>
Is this ready to merge from a technical point of view? @k-yle @tyrasd ? I resolved conflicts that happened after merging #1237 and updated the icons.json that was generated during one of the npm run commands. The is released on https://rapideditor.github.io/temaki/docs/ so that should work as well. I am wondering where the updated icon will be fetched. Temaki is not in the package.json of this repo and not in the schema builder repo. So it looks like the consumers of this repo need to handle adding the icon libraries themselves like in id. So from my point of view this can be merged. Any objections? |
I believe so, but iD will need to update temaki before the next release. I was hoping @dependabot would do it, but the bot seems to limit itself to 5 open PRs. So I've created openstreetmap/iD#10280
Yes, in iD's case, running |
Now that openstreetmap/iD#10280 is merged, I believe this is ready to be merged |
A preset was recently added for
amenity=bicycle_wash
- see #1032.This PR creates a preset for the similar approved tag
man_made=footwear_decontamination
.It is currently limited to Australia and New Zealand, since I'm not aware of anywhere else in the world where these features exist. However, I see that
man_made=carpet_hanger
(#452) is a global preset, despite only existing in a very small number of countries. So maybe it's okay to make this a global preset?