Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tagging crossing without specifying variety (just highway=crossing) #834

Closed
matkoniecz opened this issue Mar 23, 2023 · 6 comments · Fixed by #837
Closed

Allow tagging crossing without specifying variety (just highway=crossing) #834

matkoniecz opened this issue Mar 23, 2023 · 6 comments · Fixed by #837
Labels
enhancement New feature or request

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Mar 23, 2023

Sometimes memory or aerial is not good enough to specify exact one 0 for example presence of traffic signals may be not entirely clear.

On node within way:

screen01

@tyrasd tyrasd added the enhancement New feature or request label Mar 24, 2023
@tyrasd
Copy link
Member

tyrasd commented Mar 24, 2023

👍 This would require to make the highway/_crossing.json preset searchable and potentially renaming it to something like Crossing (Unspecified Type).

@1ec5
Copy link
Contributor

1ec5 commented Mar 24, 2023

Just “Crossing” is probably sufficient. There are some other unspecified-type presets that we give simpler names, such as “Building”. But if we need to differentiate, I’d suggest saying something about a “path–road crossing” or somesuch, to differentiate it from “Railway–Road Crossing” and “Railway–Railway Crossing”. (The standard real-world term for these is “road crossing”, but users could be confused about when they’re supposed to use one preset versus another.)

matkoniecz added a commit to matkoniecz/id-tagging-schema that referenced this issue Mar 24, 2023
@matkoniecz
Copy link
Contributor Author

What about "Pedestrian Road Crossing"? path has a bit messy implications as a term, some are sure that it is invalid for sidewalks (which is BTW causing problem with people retagging highway=path surface=paved bicycle=designated foot=designated segregated=yes)

@1ec5
Copy link
Contributor

1ec5 commented Mar 24, 2023

“Pedestrian Road Crossing” would be an accurate description of most occurrences of highway=crossing. However, in many regions, it’s also normal to use highway=crossing for where a cycleway crosses a road or a footway crosses a cycleway. On the other hand, the icon already depicts a pedestrian, so it’d be no more confusing than before.

@matkoniecz
Copy link
Contributor Author

Is it possible to have different preset match based on way where it is a vertex? Probably no.

@tyrasd
Copy link
Member

tyrasd commented Mar 28, 2023

Is it possible to have different preset match based on way where it is a vertex? Probably no.

No, that's not currently possible in the tagging schema, unfortunately. iD could however implement a validation rule that any highway=crossing node should always be on a highway=* way (and any footway/cycleway=crossing way should intersect a highway=* way). iD could also suggest a fix to convert the highway=crossing mapped on – say – a railway to the appropriate key (railway=crossing in that case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants