-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Hobby Shop preset #24
Comments
@maro-21 I agree people should use more specific tags if they exist. But it's also useful to have a general category for some cases, as evidenced by the hundreds of uses of the tag. Some shops brand themselves as hobby shops after all—there are five entries in the NSI. Anyway, you'll need to get more buy-in from the community before we can remove an existing preset like this. You can't just edit the wiki and open an iD issue 😄 |
Not sure it should be removed but it would definitely help to have the hobby term added to other presets. I've been looking at this tag recently and there is definitely a large percentage of them which could be tagged as collector, craft or model shops. Though some are hard to classify and could be covered by multiple tags. From the tag history you can see how the tag doubled in August/September 2018, which seems to be from shops added in Japan, e.g. https://www.openstreetmap.org/node/5899708383/ - they sell a variety of things. You can also see the increase of usage after the preset was added to iD in June 2019.
To be fair, the wiki has described it as an undocumented tag and suggested alternatives for 5 years. Plus, when the hobby presets/brands were added to iD/NSI last year, there was no discussion 😉 openstreetmap/iD@cd1a842 |
To be clear - the only thing I did was expanding the list of suggested replacements:
Exactly :)
This has been fixed: osmlab/name-suggestion-index@59d701f |
I think a good first step would be to make the preset "hidden" (non-searchable), so that people are more inclined towards using the more accurate shop types.
👍 good idea! |
...because no one knows what it is. See Wiki: https://wiki.openstreetmap.org/wiki/Tag:shop%3Dhobby
My hobby is OpenStreetMap - would I buy a map in a Hobby Store?:)
This preset has terms: manga, figurine, model - we already have separate presets for these ones -
shop=anime
,shop=collector
andshop=model
.I suggest addding "hobby" as a term for these presets:
shop=anime
shop=bicycle
shop=boat
shop=books
shop=brewing_supplies
shop=collector
shop=craft
shop=doityourself
shop=fishing
shop=games
shop=hunting
shop=model
shop=music
shop=musical_instrument
shop=outdoor
shop=scuba_diving
shop=sports
shop=toys
shop=video
shop=video_games
So one can easily find the right preset.
The text was updated successfully, but these errors were encountered: