Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hobby Shop preset #24

Closed
maro-21 opened this issue Aug 6, 2020 · 4 comments
Closed

Remove Hobby Shop preset #24

maro-21 opened this issue Aug 6, 2020 · 4 comments

Comments

@maro-21
Copy link

maro-21 commented Aug 6, 2020

...because no one knows what it is. See Wiki: https://wiki.openstreetmap.org/wiki/Tag:shop%3Dhobby
My hobby is OpenStreetMap - would I buy a map in a Hobby Store?:)

This preset has terms: manga, figurine, model - we already have separate presets for these ones - shop=anime, shop=collector and shop=model.

I suggest addding "hobby" as a term for these presets:

  • shop=anime
  • shop=bicycle
  • shop=boat
  • shop=books
  • shop=brewing_supplies
  • shop=collector
  • shop=craft
  • shop=doityourself
  • shop=fishing
  • shop=games
  • shop=hunting
  • shop=model
  • shop=music
  • shop=musical_instrument
  • shop=outdoor
  • shop=scuba_diving
  • shop=sports
  • shop=toys
  • shop=video
  • shop=video_games

So one can easily find the right preset.

@quincylvania
Copy link
Collaborator

@maro-21 I agree people should use more specific tags if they exist. But it's also useful to have a general category for some cases, as evidenced by the hundreds of uses of the tag. Some shops brand themselves as hobby shops after all—there are five entries in the NSI.

Anyway, you'll need to get more buy-in from the community before we can remove an existing preset like this. You can't just edit the wiki and open an iD issue 😄

@boothym
Copy link

boothym commented Aug 22, 2020

Not sure it should be removed but it would definitely help to have the hobby term added to other presets.

I've been looking at this tag recently and there is definitely a large percentage of them which could be tagged as collector, craft or model shops. Though some are hard to classify and could be covered by multiple tags.

From the tag history you can see how the tag doubled in August/September 2018, which seems to be from shops added in Japan, e.g. https://www.openstreetmap.org/node/5899708383/ - they sell a variety of things. You can also see the increase of usage after the preset was added to iD in June 2019.

Screenshot_2020-08-22 Ohsome - Dashboard

Anyway, you'll need to get more buy-in from the community before we can remove an existing preset like this. You can't just edit the wiki and open an iD issue

To be fair, the wiki has described it as an undocumented tag and suggested alternatives for 5 years. Plus, when the hobby presets/brands were added to iD/NSI last year, there was no discussion 😉 openstreetmap/iD@cd1a842

@maro-21
Copy link
Author

maro-21 commented Sep 20, 2020

You can't just edit the wiki and open an iD issue

To be clear - the only thing I did was expanding the list of suggested replacements:
https://wiki.openstreetmap.org/w/index.php?title=Tag:shop%3Dhobby&diff=2017292&oldid=1806009
Everyone can see how the Wiki page looked like before my edit:
https://wiki.openstreetmap.org/w/index.php?title=Tag:shop%3Dhobby&action=history
https://wiki.openstreetmap.org/w/index.php?title=Tag:shop%3Dhobby&oldid=1806009

when the hobby presets/brands were added to iD/NSI last year, there was no discussion cd1a842

Exactly :)

Some shops brand themselves as hobby shops after all—there are five entries in the NSI.

This has been fixed: osmlab/name-suggestion-index@59d701f

@quincylvania quincylvania transferred this issue from openstreetmap/iD Nov 10, 2020
@tyrasd
Copy link
Member

tyrasd commented Dec 16, 2021

I think a good first step would be to make the preset "hidden" (non-searchable), so that people are more inclined towards using the more accurate shop types.

it would definitely help to have the hobby term added to other presets.

👍 good idea!

matkoniecz added a commit to matkoniecz/id-tagging-schema that referenced this issue Mar 17, 2023
matkoniecz added a commit to matkoniecz/id-tagging-schema that referenced this issue Mar 17, 2023
tyrasd pushed a commit that referenced this issue Mar 21, 2023
tyrasd pushed a commit that referenced this issue Mar 21, 2023
@tyrasd tyrasd closed this as completed in b9f35b5 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants