Enable territory-aware address hints (with proper Hong Kong and Macao address formats) - #12704
Open
Vectorial1024 wants to merge 3 commits into
Open
Enable territory-aware address hints (with proper Hong Kong and Macao address formats)#12704Vectorial1024 wants to merge 3 commits into
Vectorial1024 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supercedes the following PRs:
This fixes #10906.
While attempting to tackle #10906, I have previously attempted to "keep it fancy", which has been a grave mistake. the detection PR has nothing to confirm it is indeed working, and the format PR has no mechanism to demonstrate the updated formats. As such, both PRs could not be merged. I am deeply sorry about the undue progress blocking.
Territory Detection (10914)
As guided by #10899 (comment) , this PR enables the editor to look at the territory-level country code. It turns out the editor only looks at sovereign country codes to generate address format hints, which unfortunately means it omits the formats of Hong Kong and Macao, both non-sovereign and use their colonial address hint formats distinct from the suzerain PRC format.
Format Documentation (10907)
While reading #10899 (comment) , it is discovered that the editor does not currently know about Hong Kong's address format. Also, the Macao address format is inaccurate. Both should be documented/updated.
Address levels above "city" are removed because both are essentially city-states. Postcodes are omitted because both (Hong Kong, Macao) do not use them. Detailed indoor addresses are added owing to the dense urban development in both cities.
Pinging past participants and interested parties: @Kovoschiz , @k-yle , @matkoniecz , @novolife, @tyrasd