Focus the selected indoor level

[koharachan]

Summary

• focus the selected indoor level or layer when the selection has level/layer information
• dim other visible floors while keeping the selected feature, same-floor features, and containing building context visible
• sort focused indoor area fills above other floors

Testing

• npm run test:once -- test/spec/renderer/indoor_focus.js
• npx eslint modules/renderer/map.js test/spec/renderer/indoor_focus.js
• git diff --check

[matkoniecz]

focus the selected indoor level or layer when the selection has level/layer information

please, post screenshot of this in action

[koharachan]

[koharachan]

Another saying is that this feature has been working on https://map.osm.asia/id for some time now.

[matkoniecz]

Is it actually working if other features are on the same level? Screenhot seems to show case where no other objects are undimmed

[koharachan]

It works. I have the video.

[matkoniecz]

Can you share it then?

[koharachan]

output_cpu_hevc.mp4

Yes, the file I just uploaded was too large. It took a lot of time to compress it.

[koharachan]

This is at 21.43/24.79560/113.62701 in OSM.

[koharachan]

You can check the values here to see if it’s working properly.

[koharachan]

My Microsoft Translate might not be very effective. If you can’t understand what I’m saying, I’ll try another translation method.

[matkoniecz]

I have not looked at code yet but from video it looks really great!

[tordans]

It looks like we can test this at https://map.osm.asia/id/#map=21.43/24.79555/113.62698&locale=en&background=EsriWorldImagery with this setting:

A few quit observations:

• we need some UI that explains what is going on. Like a info line at the top left of the map that says something like "Current focus is level 1;2;3;4;5;6"
• likely some settings like map.osm.asia/id has; but that should be store in the URL (maybe also local storage)
• we should explain better why https://map.osm.asia/id/#map=21.43/24.79555/113.62698&locale=en&background=EsriWorldImagery&id=w1530574395 does nothing (assuming no level=*) and https://map.osm.asia/id/#map=21.43/24.79555/113.62698&locale=en&background=EsriWorldImagery&id=w1507653226 does something…
• I am not sure that the highlight node (example) (highlights all connected arms) vs. line (example) (only highlights this way or related data with same level, I assume?) is easy to understand now

[tordans]

Off topic: What are the conditions again for the branch preview in iD?

[koharachan]

You’re right.But https://map.osm.asia/id/#map=21.43/24.79555/113.62698&locale=en&background=EsriWorldImagery&id=w1530574395 Maybe your card is stuck.
Look!

These are things that need to be done.

• we need some UI that explains what is going on. Like a info line at the top left of the map that says something like "Current focus is level 1;2;3;4;5;6

[koharachan]

@tordans https://map.osm.asia/id/#map=21.43/24.79555/113.62698&locale=en&background=EsriWorldImagery&id=w1507653226

I’m completely unable to reproduce your situation.

[koharachan]

It seems like local storage not merged in?
It's in https://github.com/koharachan/BetteriD,It’s a complete implementation.
Maybe there’s a problem with my work. Let me check it.

[koharachan]

But here’s how I think about it: If there’s a mountain road where all the lines are almost connected, and a tunnel connects these two sections, then the node-based approach might cause many unrelated elements to also become “lit up” (if I’m wrong, please correct me. Thank you.)