Skip to content

move power points from point layer to power layer - #12523

Draft
matkoniecz wants to merge 4 commits into
openstreetmap:developfrom
matkoniecz:patch-13
Draft

move power points from point layer to power layer#12523
matkoniecz wants to merge 4 commits into
openstreetmap:developfrom
matkoniecz:patch-13

Conversation

@matkoniecz

Copy link
Copy Markdown
Collaborator

fixes #8100

@matkoniecz matkoniecz left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason has no effect at all

@matkoniecz

Copy link
Copy Markdown
Collaborator Author

actually, before I will change tests so they pass in LLM fashion...

should be point power features actually be removed from point POI layer?

@tyrasd

tyrasd commented Jul 10, 2026

Copy link
Copy Markdown
Member

I would say so. It does seem only logical, and fixes usability issues such as #8100.

I guess an argument could be made that if we change/fix it for power features, we should treat other feature types consistently, e.g.:

  • water point features like natural=spring
  • highway point features like traffic signs
  • railway point features like stations
  • indoor point features
  • and so on

@matkoniecz

matkoniecz commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

and fixes usability issues such as #8100.

I though about changing logic in https://github.com/openstreetmap/iD/blob/develop/modules/renderer/features.js#L497 instead

If I treat it correctly currently if something matches multiple groups and any group is hidden such preset hides

maybe instead if matches multiple groups then if any group is visible then preset continues to be visible?

Compare https://www.openstreetmap.org/edit?editor=id&node=11281393359#map=20/50.0975248/20.0250373 map data: power generator point remains visible even with all groups except power one being disable

but adding more is blocked

screen-2026-07-10-18-07-09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Power poles and layers

2 participants