move power points from point layer to power layer - #12523
Conversation
matkoniecz
left a comment
There was a problem hiding this comment.
for some reason has no effect at all
|
actually, before I will change tests so they pass in LLM fashion... should be point power features actually be removed from point POI layer? |
|
I would say so. It does seem only logical, and fixes usability issues such as #8100. I guess an argument could be made that if we change/fix it for power features, we should treat other feature types consistently, e.g.:
|
I though about changing logic in https://github.com/openstreetmap/iD/blob/develop/modules/renderer/features.js#L497 instead If I treat it correctly currently if something matches multiple groups and any group is hidden such preset hides maybe instead if matches multiple groups then if any group is visible then preset continues to be visible? Compare https://www.openstreetmap.org/edit?editor=id&node=11281393359#map=20/50.0975248/20.0250373 map data: power generator point remains visible even with all groups except power one being disable but adding more is blocked
|

fixes #8100