Skip to content

Conversation

@krishnan05
Copy link

@krishnan05 krishnan05 commented Dec 22, 2025

Problem

The Mapillary Data panel violates expected parent/child toggle behavior (#11671).
Disabling the Mapillary master checkbox does not disable its subordinate overlays, leading to an inconsistent and confusing UI state.

Screenshots

Before
Parent Mapillary toggle disabled, but child overlays remain enabled:
Before

After
Disabling the Mapillary parent toggle correctly disables all child overlays:
After

Solution

This change enforces correct parent/child toggle logic for Mapillary overlays:

  • Disabling the Mapillary parent checkbox now disables all Mapillary child overlays.
  • Enabling or disabling child overlays updates the parent checkbox state accordingly.
  • Child overlays remain independently configurable when the parent is enabled.

Scope

  • UI logic only (Photo Overlays / Mapillary section)
  • No changes to rendering, data loading, or Mapillary integration

Testing

  • Toggled Mapillary parent checkbox on/off
  • Verified all Mapillary child overlays follow parent state
  • Verified parent state updates when child overlays are toggled individually

Fixes #11671

@tordans
Copy link
Collaborator

tordans commented Dec 22, 2025

This is not #11671 (comment) is it?

@krishnan05
Copy link
Author

This is not #11671 (comment) is it?

You’re right — this PR addresses only the parent/child toggle logic issue described in #11671, not the broader UI restructuring discussed later in the thread.

The goal here was to fix the inconsistent “master switch” behavior without changing the existing panel structure. The broader questions around how photo and detection providers are grouped and presented go beyond a simple bug fix and likely need a more deliberate UX and architectural discussion, including panel structure and state ownership.

It may be useful to discuss possible directions or scope this into follow-up work, depending on what maintainers think makes the most sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mapillary Data panel logic wrong

2 participants