-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highway=cyclist_waiting_aid
side
gets reversed with the way
#10128
Comments
To avoid making things too easy:
I'm sorry that the tagging has such a pitfall in this case. (This issue is also mentioned in this forum thread) |
oh… I had not thought of that. This might be pretty hard to handle 100% correctly. 😬 But how likely is it that this will actually be a real problem in practice? I mean, given that these features are by definition always placed in front of certain obstacles like intersections: When the direction of travel of, say, a oneway bikepath is flipped in reality, then that would mean that previously existing waiting aids are now all placed in locations where they are not useful anymore (e.g. right after intersections instead of right before them). So… realistically, the waiting aids would have been moved in reality as well, meaning that they would have to be fully remapped accordingly anyway. 🤔 Right? |
Is this the only feature that uses |
AFAICS, the wiki does not document any uses of the The usual convention in OSM is that |
Initially, the use of the side tag in context of waiting aids was also considered in line direction, but it turned out that this can easily be misunderstood by mappers (see this example). The idea was then to use it from the cyclist's perspective in case of waiting aids. Due to the missing documentation of other uses of The assumption in case of waiting aids was, that direction of travel/movement-dependent use results in more correct/less incorrect data. Possible mistakes due to direction flips should be the absolute exception (especially as waiting aids are often on oneway paths, where this problem does not exist when flipping). But of cause, this makes things hard for editor developers. |
That would seem to be iffy, the whole issue is that the side of the rest from the cyclists perspective has nothing to do with the way direction, and that somebody surveying the way correctly could get the side of the rests right and the way direction wrong and many other possible combinations. Note that there are additional complications if the rest is co-mapped with a traffic_sign object. |
This allows per key exceptions to the usual way/node tag reversal rules by specifying the key and a JosmFilter expression that has to match. See openstreetmap/iD#10128
This allows per key exceptions to the usual way/node tag reversal rules by specifying the key and a JosmFilter expression that has to match. See openstreetmap/iD#10128
This allows per key exceptions to the usual way/node tag reversal rules by specifying the key and a JosmFilter expression that has to match. See openstreetmap/iD#10128
I think it's early enough that we should just redefine the That leaves only 46 features that someone else needs to review. Worst case a Redefining the tag seems like a better option than permanent confusion about how to handle this tag in each editor... |
Just in case anybody needs some inspiration :-). My current solution to the issue is to reverse the tag except if the node in questions matches (JOSM filter/search language):
which neatly takes care of the oneway aspect. |
This allows per key exceptions to the usual way/node tag reversal rules by specifying the key and a JosmFilter expression that has to match. See openstreetmap/iD#10128
This allows per key exceptions to the usual way/node tag reversal rules by specifying the key and a JosmFilter expression that has to match. See openstreetmap/iD#10128
This allows per key exceptions to the usual way/node tag reversal rules by specifying the key and a JosmFilter expression that has to match. See openstreetmap/iD#10128
When a way is reversed and there is a
highway=cyclist_waiting_aid
(openstreetmap/id-tagging-schema#1066 / openstreetmap/id-tagging-schema#1069) with aside
value, then this value also gets "reversed". However,side
represents the side of the waiting aid from the cyclist's perspective, not from the way's perspective, so this actually sets an incorrect value.For example, add
highway=cyclist_waiting_aid
+direction=forward
+side=right
to a way's node. Then reverse the parent way. Observe thatdirection=backward
got swapped correctly, but alsoside=left
got swapped, which is now on the incorrect side.The text was updated successfully, but these errors were encountered: