Localize the format of numbers in translated strings (close #7993)

openstreetmap · Sep 15, 2020 · f28d41b · f28d41b
1 parent 007cc1d
commit f28d41b
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/modules/core/localizer.js b/modules/core/localizer.js
@@ -258,10 +258,19 @@ export function coreLocalizer() {
                 }
             }
             if (typeof result === 'string') {
-              for (let k in replacements) {
-                const token = `{${k}}`;
+              for (let key in replacements) {
+                let value = replacements[key];
+                if (typeof value === 'number' && value.toLocaleString) {
+                  // format numbers for the locale
+                  value = value.toLocaleString(locale, {
+                    style: 'decimal',
+                    useGrouping: true,
+                    minimumFractionDigits: 0
+                  });
+                }
+                const token = `{${key}}`;
                 const regex = new RegExp(token, 'g');
-                result = result.replace(regex, replacements[k]);
+                result = result.replace(regex, value);
               }
             }
           }