feat: status-report impact

[mxkaske]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
openstatus-dashboard	Canceled		Jun 11, 2026 7:23pm
openstatus-status-page	Canceled		Jun 11, 2026 7:23pm
openstatus-web	Canceled		Jun 11, 2026 7:23pm

[cubic-dev-ai]

1 issue found across 9 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/dashboard/src/components/forms/status-report/component-impact-field.tsx">

<violation number="1" location="apps/dashboard/src/components/forms/status-report/component-impact-field.tsx:62">
P2: `allowUnset` mode is not reversible: after selecting an impact, users cannot set the component back to "No change" (unset).</violation>
</file>

<file name="packages/ui/src/components/blocks/status-events.tsx">

<violation number="1" location="packages/ui/src/components/blocks/status-events.tsx:412">
P3: Use a stable item key here instead of the array index to avoid incorrect element reuse if the impact list changes.</violation>
</file>

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>

[mxkaske]

@claude review

[claude]

Claude finished @mxkaske's task in 2m 56s —— View job

---

Code Review

• Gather context
• Review key changed files
• Analyze unresolved issues from prior review
• Post findings

---

Summary

This PR introduces per-component impact tracking for status reports — a solid feature that correctly wires the data model (new join table), service layer, UI forms, and the status-page rendering. The architecture is clean and the batched query design in enrichReportsBatch avoids N+1 nicely.

Two issues from the prior review remain unresolved, and I found two additional ones.

---

Issues

P2 — allowUnset mode is not reversible

component-impact-field.tsx:43-85

Once a user selects any impact in allowUnset=true mode (used in the edit-update flow), there is no way to revert the component to "No change". The SelectContent only lists the four pageComponentImpact enum values — there is no unset option. The setImpact helper always inserts an entry; it never removes one.

Fix needed: When allowUnset=true, add a sentinel item to the top of SelectContent (e.g. value "__unset__" with label matching the placeholder), and handle it in setImpact by filtering the entry out instead of upserting it. Concretely:

function setImpact(id: number, next: string) {
  const rest = value.filter((v) => v.pageComponentId !== id);
  if (next === "__unset__") {
    onValueChange(rest);  // removes the entry → "No change"
  } else {
    onValueChange([...rest, { pageComponentId: id, impact: next as PageComponentImpact }]);
  }
}

And in the JSX:

<SelectContent>
  {allowUnset && (
    <SelectItem value="__unset__" className="text-muted-foreground font-mono">
      {placeholder}
    </SelectItem>
  )}
  {pageComponentImpact.map((option) => (
    <SelectItem key={option} value={option} ...>
  ))}
</SelectContent>

Fix this →

---

P3 — key={i} in StatusEventTimelineImpact

status-events.tsx:412

Using array index as key causes React to reuse the wrong DOM elements if the changes list is reordered or spliced. The items have a stable name field — use that instead.

// before
key={i}
// after
key={change.name}

Fix this →

---

P3 — In-place .sort() mutates row.updates

columns.tsx:162

accessorFn: (row) =>
  row.updates.sort((a, b) => a.date.getTime() - b.date.getTime())[0]
    ?.date ?? row.createdAt,

Array.prototype.sort sorts in-place. enrichReportsBatch returns updates ordered newest-first (it queries orderBy(desc(...date))). This accessor will silently reorder that array to oldest-first on first render, which may affect any other code that reads row.updates expecting newest-first ordering (e.g. worstCurrentImpact → currentImpactsFromUpdates).

currentImpactsFromUpdates re-sorts internally so it is OK, but it is still a latent hazard. Use a shallow copy:

accessorFn: (row) =>
  [...row.updates].sort((a, b) => a.date.getTime() - b.date.getTime())[0]
    ?.date ?? row.createdAt,

Fix this →

---

Nit — Comment discipline in new code

status-events.tsx:377-381

The new StatusEventTimelineImpact JSDoc block is 5 lines; CLAUDE.md caps new doc comments at 3 lines max ("one short line where possible, 3 lines max. Never write multi-paragraph JSDoc blocks"). The two-sentence description could be collapsed to one:

/** Hover-card label showing the worst impact among this update's component changes. */

---

What looks good

• Service layer correctness: requireScope + emitAudit + withTransaction pattern followed throughout; the dedup refine on componentImpactsSchema prevents PK violations at the schema level before DB writes.
• TOCTOU closed: validatePageComponentIds runs inside the caller's transaction, eliminating the race between validation and insert.
• Batch loading: enrichReportsBatch loads updates, impact rows, and page components in 3 queries regardless of list size — solid fix for the N+1 pattern.
• Resolve auto-clear: The logic in addStatusReportUpdate that synthesizes clears for still-non-operational components when status === "resolved" is correct. The named set properly prevents double-writing a component that appears in both componentImpacts and the auto-clear list.
• accessorFn / getValue fix: columns.tsx now uses row.getValue<PageComponentImpact | null>("impact") instead of calling worstCurrentImpact a second time in the cell — the prior duplicate-computation complaint is resolved.

[cubic-dev-ai]

2 issues found across 7 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/test.yml">

<violation number="1">
P1: CI uses unbounded 'latest' Bun version instead of a pinned exact version, breaking build reproducibility.</violation>
</file>

<file name=".github/workflows/dx.yml">

<violation number="1">
P2: Using 'latest' for bun-version instead of a pinned version removes build reproducibility in CI</violation>
</file>

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>