Skip to content

Commit

Permalink
Remove resize_server() helper
Browse files Browse the repository at this point in the history
This only existed to return the resized server. This is not actually
needed anywhere in our code. Remove it and use the base tempest
helper.

Change-Id: If47a1a233af103c88587959af20be67391c63aa3
  • Loading branch information
notartom committed Aug 27, 2021
1 parent 5864665 commit 4e5802f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
8 changes: 0 additions & 8 deletions whitebox_tempest_plugin/api/compute/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,6 @@ def create_flavor(self, ram=64, vcpus=2,
**extra_specs)
return flavor

def resize_server(self, server_id, new_flavor_id, **kwargs):
# override the function to return the resized server
# TODO(stephenfin): Add this to upstream
super(BaseWhiteboxComputeTest, self).resize_server(
server_id, new_flavor_id, **kwargs)

return self.servers_client.show_server(server_id)['server']

def copy_default_image(self, **kwargs):
"""Creates a new image by downloading the default image's bits and
uploading them to a new image. Any kwargs are set as image properties
Expand Down
4 changes: 2 additions & 2 deletions whitebox_tempest_plugin/api/compute/test_cpu_pinning.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def test_resize_pinned_server_to_unpinned(self):

flavor_b = self.create_flavor(vcpus=self.vcpus,
extra_specs=self.shared_cpu_policy)
server = self.resize_server(server['id'], flavor_b['id'])
self.resize_server(server['id'], flavor_b['id'])
cpu_pinnings = self.get_server_cpu_pinning(server['id'])

self.assertEqual(
Expand All @@ -203,7 +203,7 @@ def test_resize_unpinned_server_to_pinned(self):

flavor_b = self.create_flavor(vcpus=self.vcpus,
extra_specs=self.dedicated_cpu_policy)
server = self.resize_server(server['id'], flavor_b['id'])
self.resize_server(server['id'], flavor_b['id'])
cpu_pinnings = self.get_server_cpu_pinning(server['id'])

self.assertEqual(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ def test_resize_file_backed_server_on_diff_host(self):
):
server = self.create_test_server()
self._assert_shared_mode_and_file_type(server)
server = self.resize_server(
server['id'], self.new_flavor['id'])
self.resize_server(server['id'], self.new_flavor['id'])
self._assert_shared_mode_and_file_type(server)

def test_live_migrate_file_backed_server(self):
Expand Down

0 comments on commit 4e5802f

Please sign in to comment.