Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OVNcontroller and OVSnodeOsp to cvs-generator #14

Merged

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Jul 3, 2020

this adds new added OVNcontroller and OVSnodeOsp CRDs to the
csv-generator, also adds the scc generation as it is not handled
by olm correct.

@stuggi stuggi marked this pull request as draft July 3, 2020 15:55
@stuggi stuggi marked this pull request as ready for review July 6, 2020 08:25
@stuggi stuggi requested a review from dprince July 6, 2020 08:25
@stuggi stuggi marked this pull request as draft July 6, 2020 11:17
@stuggi stuggi force-pushed the add_ovn_crd_to_csv_generator branch 2 times, most recently from ccb95a1 to 55c34ed Compare July 6, 2020 12:28
cmd/manager/main.go Outdated Show resolved Hide resolved
@stuggi stuggi force-pushed the add_ovn_crd_to_csv_generator branch from 55c34ed to cb89fc6 Compare July 6, 2020 13:36
Copy link
Contributor

@mrkisaolamb mrkisaolamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stuggi stuggi force-pushed the add_ovn_crd_to_csv_generator branch from cb89fc6 to 9fffb81 Compare July 6, 2020 14:37
@stuggi stuggi marked this pull request as ready for review July 6, 2020 14:38
this adds new added OVNcontroller and OVSnodeOsp CRDs to the
csv-generator, also adds the scc generation as it is not handled
by olm correct.

Also changes the CRD version to v1beta as otherwise OLM failed
to install the plan.
@stuggi stuggi force-pushed the add_ovn_crd_to_csv_generator branch from 9fffb81 to 15243fa Compare July 6, 2020 14:42
@stuggi stuggi merged commit 04d3f19 into openstack-k8s-operators:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants