-
Notifications
You must be signed in to change notification settings - Fork 55
WIP: Add support for External Keystone Service #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmendiza The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0636e0d41791487589955f58fe17b071 ❌ openstack-k8s-operators-content-provider FAILURE in 8m 57s |
3ccee68 to
4ebeb65
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aac4c90d99a04ad1beac31fb4502f812 ❌ openstack-k8s-operators-content-provider FAILURE in 9m 33s |
4ebeb65 to
227b00b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/13d740041bf24217a22f1de016ce4efa ❌ openstack-k8s-operators-content-provider FAILURE in 9m 05s |
This patch adds a new `ExternalKeystoneAPI` property to KeystoneAPI to enable the use of an existing Keystone Service that is external to the OpenShift environment used to run this operator. For example, a multi-region deployment where one region is running a centralized Keystone service can use this to deploy additional regions that can use the centralized Keystone service without the need to run their own instance of Keystone. Assisted-by: Cursor (Auto Model)
227b00b to
0e4e747
Compare
| ) | ||
|
|
||
| var ( | ||
| // interfaceBundleKeys maps endpoint winterfaces to their corresponding key in the CA bundle secret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/winterfaces/interfaces/
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ef704189ca0d4a08ac566e2756bb91c0 ❌ openstack-k8s-operators-content-provider FAILURE in 8m 57s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b5471949529848f0aae25cd0855f98aa ❌ openstack-k8s-operators-content-provider FAILURE in 9m 21s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8e97f5c52be1434c822b2bc4304b1a95 ❌ openstack-k8s-operators-content-provider FAILURE in 9m 16s |
|
/recheck |
|
/test keystone-operator-build-deploy-kuttl |
Generate the clouds.yaml for the External Keystone API.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/15db4974754f4f8dbeab5a62c88255c3 ❌ openstack-k8s-operators-content-provider FAILURE in 10m 02s |
Refactor the change added in this branch to pick the right bundle internally based on KeystoneAPI spec instead of making callers of GetAdminServiceClient figure that out. The client will continue to default to the internal interface, but use the public interface when using an external Keytone API.
|
@dmendiza: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/63d602ef9db54a5e850cc9eac9415232 ❌ openstack-k8s-operators-content-provider FAILURE in 11m 38s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2385a873c8954c189a1fdf321f50559f ❌ openstack-k8s-operators-content-provider FAILURE in 9m 22s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5b01fa6733d54721be36fcdf0bd1d8ae ❌ openstack-k8s-operators-content-provider FAILURE in 12m 58s |
This patch adds a new
ExternalKeystoneAPIproperty to KeystoneAPI to enable the use of an existing Keystone Service that is external to the OpenShift environment used to run this operator.For example, a multi-region deployment where one region is running a centralized Keystone service can use this to deploy additional regions that can use the centralized Keystone service without the need to run their own instance of Keystone.
Assisted-by: Cursor (Auto Model)
The following dependencies are not strictly necessary, but it is useful to include them here for testing the setting for region:
Depends-On: openstack-k8s-operators/octavia-operator#558
Depends-On: openstack-k8s-operators/telemetry-operator#825
Depends-On: openstack-k8s-operators/barbican-operator#321
Depends-On: openstack-k8s-operators/manila-operator#513
Depends-On: openstack-k8s-operators/nova-operator#1054
Depends-On: openstack-k8s-operators/cinder-operator#589
Depends-On: openstack-k8s-operators/glance-operator#852
Depends-On: openstack-k8s-operators/neutron-operator#588