Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COS integration: make prom-api configurable #1261

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

sabaini
Copy link
Contributor

@sabaini sabaini commented Sep 2, 2024

Refactor integration tests and make retrieving prom-api configurable

Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just 2 nits

zaza/openstack/charm_tests/ceph/mon/integration.py Outdated Show resolved Hide resolved
zaza/openstack/charm_tests/ceph/mon/integration.py Outdated Show resolved Hide resolved
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
@sabaini sabaini merged commit 37e0dd6 into openstack-charmers:master Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants