Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for installer repo to ghmerge #194

Closed
wants to merge 5 commits into from

Conversation

nhorman
Copy link
Contributor

@nhorman nhorman commented May 17, 2024

Adds installer repo as a merge WHAT target

Note also that I did some addional gymnastics to add OpenSSL-Query to the PERL5LIB path here to avoid having to copy those modules to the installer directory

@nhorman nhorman self-assigned this May 17, 2024
@t8m
Copy link
Member

t8m commented May 17, 2024

Please look at all the changes needed in this commit 3ab4788

@nhorman
Copy link
Contributor Author

nhorman commented May 17, 2024

fixed

Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with the typo corrected

review-tools/gitaddrev Outdated Show resolved Hide resolved
@t8m t8m requested a review from paulidale May 20, 2024 12:53
review-tools/gitaddrev Show resolved Hide resolved
review-tools/gitaddrev Show resolved Hide resolved
review-tools/gitaddrev Outdated Show resolved Hide resolved
@t8m
Copy link
Member

t8m commented Aug 16, 2024

@mattcaswell please re-review

@t8m
Copy link
Member

t8m commented Sep 3, 2024

Merged. Thank you.

@t8m t8m closed this Sep 3, 2024
openssl-machine pushed a commit that referenced this pull request Sep 3, 2024
Adds installer repo as a merge WHAT target

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants