apps/req.c: Always set permissions for private key output #29397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key output will be always private. Reported with a proposed fix by Stanislav Fort (Aisle Research).
t8m
added
branch: master
mattcaswell
approved these changes
Dec 15, 2025
beldmit
approved these changes
Dec 15, 2025
Member
beldmit
left a comment
beldmit
left a comment
There was a problem hiding this comment.
LGTM
Do we exempt tests here?
beldmit
added
approval: done
Member
Author
I do not think it really is worth it. |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
jogme
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Dec 17, 2025
The key output will be always private. Reported with a proposed fix by Stanislav Fort (Aisle Research). Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #29397)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 17, 2025
The key output will be always private. Reported with a proposed fix by Stanislav Fort (Aisle Research). Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #29397)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 17, 2025
The key output will be always private. Reported with a proposed fix by Stanislav Fort (Aisle Research). Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #29397)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 17, 2025
The key output will be always private. Reported with a proposed fix by Stanislav Fort (Aisle Research). Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #29397)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 17, 2025
The key output will be always private. Reported with a proposed fix by Stanislav Fort (Aisle Research). Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #29397)
Contributor
|
Merged to all active branches. Thank you! |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 17, 2025
The key output will be always private. Reported with a proposed fix by Stanislav Fort (Aisle Research). Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #29397)
websurfer5
pushed a commit
to websurfer5/openssl
that referenced
this pull request
Dec 23, 2025
The key output will be always private. Reported with a proposed fix by Stanislav Fort (Aisle Research). Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#29397)
websurfer5
pushed a commit
to websurfer5/openssl
that referenced
this pull request
Dec 23, 2025
The key output will be always private. Reported with a proposed fix by Stanislav Fort (Aisle Research). Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#29397)
websurfer5
pushed a commit
to websurfer5/openssl
that referenced
this pull request
Dec 29, 2025
The key output will be always private. Reported with a proposed fix by Stanislav Fort (Aisle Research). Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#29397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key output will be always private.
Reported with a proposed fix by Stanislav Fort (Aisle Research).