QUIC SSTREAM: Fix bug in ossl_quic_sstream_is_totally_acked#22580
Closed
hlandau wants to merge 1 commit intoopenssl:masterfrom
Closed
QUIC SSTREAM: Fix bug in ossl_quic_sstream_is_totally_acked#22580hlandau wants to merge 1 commit intoopenssl:masterfrom
hlandau wants to merge 1 commit intoopenssl:masterfrom
Conversation
ossl_quic_sstream_is_totally_acked would return 0 if no data had been appended to the stream yet. Fixed and added tests.
hlandau
added
branch: master
t8m
approved these changes
Oct 31, 2023
paulidale
approved these changes
Nov 1, 2023
paulidale
added
approval: done
mattcaswell
approved these changes
Nov 1, 2023
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Member
Author
|
This should go into 3.2. |
Contributor
|
+1 for 3.2 |
Member
|
Yeah - my approval counts for 3.2 |
Member
Author
|
Merged to master and 3.2. Thanks for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 2, 2023
ossl_quic_sstream_is_totally_acked would return 0 if no data had been appended to the stream yet. Fixed and added tests. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22580) (cherry picked from commit 115ee28)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 2, 2023
ossl_quic_sstream_is_totally_acked would return 0 if no data had been appended to the stream yet. Fixed and added tests. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22580)
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Nov 4, 2023
ossl_quic_sstream_is_totally_acked would return 0 if no data had been appended to the stream yet. Fixed and added tests. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl/openssl#22580) Signed-off-by: fly2x <fly2x@hitls.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ossl_quic_sstream_is_totally_acked would return 0 if no data had been appended to the stream yet. Fixed and added tests. Fixes the s_client failure hang issue mentioned in #22551.