Skip to content

Document return value of OSSL_DECODER_from_data#20327

Closed
lava wants to merge 1 commit intoopenssl:masterfrom
lava:ossl-documentation
Closed

Document return value of OSSL_DECODER_from_data#20327
lava wants to merge 1 commit intoopenssl:masterfrom
lava:ossl-documentation

Conversation

@lava
Copy link

@lava lava commented Feb 17, 2023

The return value of OSSL_DECODER_from_data() was not documented.

CLA: trivial

Checklist
  • documentation is added or updated

paulidale
paulidale approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay with trivial

@paulidale paulidale added branch: master Applies to master branch approval: review pending This pull request needs review by a committer cla: trivial One of the commits is marked as 'CLA: trivial' branch: 3.0 Applies to openssl-3.0 branch branch: 3.1 Applies to openssl-3.1 (EOL) labels Feb 20, 2023
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Feb 20, 2023
mattcaswell
mattcaswell approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with trivial

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer cla: trivial One of the commits is marked as 'CLA: trivial' labels Feb 20, 2023
@paulidale
Copy link
Contributor

paulidale commented Feb 20, 2023

Merged, thanks for the contribution.

@paulidale paulidale closed this Feb 20, 2023
openssl-machine pushed a commit that referenced this pull request Feb 20, 2023
@paulidale
Document return value of OSSL_DECODER_from_data
7e55051 
CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #20327)
openssl-machine pushed a commit that referenced this pull request Feb 20, 2023
@paulidale
Document return value of OSSL_DECODER_from_data
a57ab43 
CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #20327)

(cherry picked from commit 7e55051)
openssl-machine pushed a commit that referenced this pull request Feb 20, 2023
@paulidale
Document return value of OSSL_DECODER_from_data
1b1b145 
CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #20327)

(cherry picked from commit 7e55051)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroeckx kroeckx kroeckx approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch branch: 3.1 Applies to openssl-3.1 (EOL) severity: fips change The pull request changes FIPS provider sources

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lava @paulidale @kroeckx @mattcaswell