-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rand: Coverity fixes #12309
rand: Coverity fixes #12309
Conversation
Instead appease coverity by marking 1464986 as a false positive. Coverity is confused by the engine reference counting.
Ping for review please. |
Looks ok to me.. Would approve if I could :) |
As @mattcaswell taught me: |
@slontis and I work for the same employer, we don't approve each other's PRs. Doing so would risk merging happening. |
This pull request is ready to merge |
Merged to master, thanks for the feedback. |
Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #12309)
Instead appease coverity by marking 1464986 as a false positive. Coverity is confused by the engine reference counting. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #12309)
Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #12309)
Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #12309)
…s it. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #12309)
Mostly fixing problems with the provider friendly rand work.
Also includes a fix for a null pointer dereference in properties and the removal of an unnecessary NULL check in apps/cmp.c