Flush PAM_TEXT_INFO immediately #337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accidentally had plus signs at two lines. Some functions i havent touched fail on unused-parameter, i assume that's not an actual error. |
|
Would love to see some momentum on this issue. As MFA becomes more ubiquitous, this becomes more impactful. |
|
Could you please rebase and repush this PR? It's hard to read ATM |
|
@djmdjm i believe there's more progress in #452, which implements this exact same thing (and more), so i think we should just close this PR and continue over there. For future reference, so that i dont make ugly PRs again, would rebasing and repushing kinda be the same as squashing this entire PR/branch, or were you referencing something else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make PAM_TEXT_INFO and PAM_ERROR_MSG flush immediately.
Discussed here: https://bugzilla.mindrot.org/show_bug.cgi?id=2876 (back in 2018 lol). The old accumulating messages behavior was needed due to SSHv1.
Perhaps we should make this a config option as James suggests in the bugzilla thread.