-
Notifications
You must be signed in to change notification settings - Fork 73
Resolve crash that occurs when a connection to Keycloak fails #3822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Refactored fetchAccessToken to simplify and catch all exceptions generically
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (24.6%) is below the target coverage (25.0%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3822 +/- ##
=========================================
- Coverage 25.0% 24.6% -0.4%
- Complexity 844 849 +5
=========================================
Files 297 305 +8
Lines 16102 16516 +414
Branches 2689 2747 +58
=========================================
+ Hits 4038 4076 +38
- Misses 11580 11956 +376
Partials 484 484
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| Result.failure(sslHandShakeException) | ||
| } catch (e: Exception) { | ||
| Result.failure(e) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of omitting all these, you can retain them and add.
catch (e: Exception) {
Result.failure(e)
}At the end, to catch any missed exceptions.
…ix-auth-server-connection-crash
….com:opensrp/fhircore into bugfix/3821-fix-auth-server-connection-crash
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3821
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile