Remove the option --edit-code-command
#664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the unused --edit-code-command feature, thereby simplifying the codebase. The changes include:
- Removing the edit-code-command option, its variables, and related logic from the core source files.
- Deleting the associated test file and updating relevant Makefiles and test harness files.
- Cleaning up command-line parsing logic and output generation in the code.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/command-line-options.src/edit-code-command.at | Deleted test file for the removed edit-code-command feature |
| tests/command-line-options.at | Commented out the inclusion of the edit-code-command test file |
| tests/Makefile.in | Removed the reference to the edit-code-command test file |
| tests/Makefile.am | Removed the reference to the edit-code-command test file |
| cobj/codegen.c | Removed the joutput_edit_code_command function and its call sites; simplified class header generation |
| cobj/cobj.h | Deleted the declarations for edit_code_command and edit_code_command_is_set |
| cobj/cobj.c | Removed command-line case handling and variable declarations for edit-code-command |
tsh-hashimoto
approved these changes
Jun 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
edit-code-commandfeature from the codebase. The changes clean up related code, tests, and documentation, simplifying the project by eliminating unused functionality.This PR improves the code coverage. See #662.
Removal of
edit-code-commandfunctionality:cobj/cobj.c: Removed theedit-code-commandoption from the command-line options and associated variables and logic. (cobj/cobj.h: Deleted the declarations ofedit_code_commandandedit_code_command_is_set.cobj/codegen.c: Removed thejoutput_edit_code_commandfunction and all calls to it, along with related conditional logic.Test cleanup:
tests/Makefile.amandtests/Makefile.in: Removed references to theedit-code-command.attest.tests/command-line-options.at: Commented out the inclusion ofedit-code-command.at.tests/command-line-options.src/edit-code-command.at: Deleted theedit-code-commandtest file entirely.