Support progress in reassignments web api #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandboat
force-pushed
the
feature/show-resignment-progress-web-api
branch
from
25101bb to
6956026
Compare
chia7712
reviewed
Sep 15, 2022
There was a problem hiding this comment.
@brandboat 感謝實作這個方便的功能，不過在提供progress後，可否在from and to兩者也提供size讓使用者可以意識到我們是用資料大小來做為比對？
沒問題，這個大小指的是 from 以及 to ( |
綜合和個別都可以呈現，這樣如何？ |
收到！ |
brandboat
force-pushed
the
feature/show-resignment-progress-web-api
branch
from
6956026 to
8a880a4
Compare
|
ci 錯誤測試為 flaky test: #722, https://github.com/skiptests/astraea/actions/runs/3069517182/jobs/4958264547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #595