[DOCKER] fix randomString for macOS compatibility #1864
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use /dev/urandom with proper base64 encoding instead of /dev/random which blocks on macOS. Generate URL-safe base64 cluster ID per KIP-78.
Contributor
Author
|
@chia7712 Would you like to review this PR ? |
Contributor
|
I have merged the #1861. would you mind testing it on you local? |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
randomStringwill produce empty string on MacOS.This PR use
/dev/urandomwith proper base64 encoding instead of /dev/random which blocks on macOS. Generate URL-safe base64 cluster ID per KIP-78.This approach is tested on MacOS 26.1 and Ubuntu 24.04 on docker.
Ref: