Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONNECTOR] Add documents for connector #1367

Merged

Conversation

Haser0305
Copy link
Collaborator

#1289

這是sink部份的說明文件,還有我們打算把perf sink 與 perf source 寫在一起,不知這樣如何?

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感謝更新,大致上還不錯

@Haser0305 @chaohengstudent 現在connector 內容還有些稀缺,希望之後我們可以一起把實作完成來豐富內容

chia7712
chia7712 previously approved these changes Dec 30, 2022
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 做得很好

@chaohengstudent chaohengstudent merged commit bfeab0a into opensource4you:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants