Added table of contents and reordered email settings text to make it more clear #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a little table of contents to the email text to make sure people are aware of the full contents of the email and reordered the "check settings below" to immediately before the settings. By having it before the change password makes it less prone to be read and correctly understood
This reverts commit 3d6623b.
Added a table of contents to the email text as it may not be clear the email full length, and reorder the line to check settings below to immediately before the settings, as it could get easily forgotten and misunderstood if staying before the change password.
Rearrange emailsettings
|
Thanks @diogocsc :) |
|
@barryo do you know when this will be released? I use release, I could change to point to develop, but I'd prefer to use release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the extent of the settings email, users may need to scroll, and so miss part of the email text. Adding a table of contents helps reader to be aware what the email content is.
Also, the "check settings below" line is more effective after the password change message, as the reader will be able to understand what the sentence refers too (which is not the password change as it may be lead to believe with current text)
I agree to the Contributor License Agreement
@pierreozoux check this out.