Switch to PEP 621 project metadata; build sdist and all wheels in CI #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Fedora and check that it propagated to the Copr before announcing. Also announce to forum.image.sc. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
7z will fail if given an HTTP error page, so this is only a cleanup. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Drop obsolete test_suite and zip_safe settings. Combine multi-word keywords. Add repo and documentation URLs. PEP 621 support requires setuptools >= 61. Closes: openslide#167 Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
It's the build tool currently recommended by PyPA. Since it builds in a venv, we can stop installing some dependencies. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Member
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
1 task
The convert module doesn't use any libc APIs, so we can build on any Linux distro and auditwheel will tag the wheel as the oldest manylinux. auditwheel requires setuptools on Python 3.12 for distutils. Fixes: openslide#126 Fixes: openslide#187 Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
By omitting the `python -m build` -w argument in one job, verify that the source tarball can successfully build a wheel. Use that source tarball in releases rather than building it on a developer's machine. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
pre-commit will not support pyproject.toml, and flake8 doesn't support it yet. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch away from
setup.pyas much as possible. Drop obsoletetest_suiteandzip_safesettings. Combine multi-word keywords. Add repo and documentation URLs. Move tool configurations intopyproject.tomlwhere possible. PEP 621 support requires setuptools ≥ 61.Build the source tarball and wheels for Linux, macOS, and Windows in GitHub Actions using the Python
buildpackage. The Linux wheels supportmanylinux1and above, after postprocessing withauditwheel, because the extension module doesn't use libc functions. The macOS wheels are multi-arch on Python 3.9+.While we're here, minor release procedure updates: update the Fedora package and check that it propagated to the Copr before announcing the release; additionally announce releases to forum.image.sc.