Log start2 lfs#2105
Merged
Merged
Conversation
Add some more comments to reflect actual offstes inside mainConfig_t Add two conditional "short"s to make (implicit) padding visible inside mainConfig_t For testing enable LOG2LFS for all platforms with LFS
Disable feature ENABLE_LOG2LFS by default
|
🎉 This PR is included in version 1.18.289 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement logging of startup messages to LFS - new version of #2076:
logStartup2lfs [optional seconds] [optional repeats]Enable writing startup log to lfs for this number of seconds.seconds: up to 30 - default 10srepeats: default only onceDisable (running and further logging to LFS ) with
logStartup2lfs 0Feature an be enabled (if LFS is enabled, too) with
#define ENABLE_LOG2LFS 1in obk_config.hExample use:
Start logging first ten seconds of messages to LFS on next start:
logStartup2LFSLog the next 3 startups to LFS for 15 seconds :
logStartup2LFS 15 3Also commented mainConfig_t member addresses (often dependent on the platform) and introduced two "short" vars to make (prior "hidden/implicit") padding visible.