Skip to content

Commit

Permalink
Update core.yaml (#1024)
Browse files Browse the repository at this point in the history
commit fabric8-services/fabric8-wit@2661cf8
Author: Konrad Kleine <193408+kwk@users.noreply.github.com>
Date:   Tue Aug 7 15:40:55 2018 +0200

Provide join lock down  (fabric8-services/fabric8-wit#2211)
    
This includes an extra-condition in the `ON` part of the table `JOINS` for areas, codebases and iterations to only join those tables filtered by their space ID. I'm not sure though if this really fixes the problem (see fabric8-services/fabric8-wit#2210 (comment)).
    
## TODO
    
As of yesterday's (07.08.2018) discussion with @aslakknutsen we did experiments and found that in order to keep the rows in the search small, we have to establish a condition on the final SQL `WHERE` clause that limits the selection to work items from a particular space. At the moment, the current `/api/search` endpoint is so generic that it doesn't require a limitation by space on the root of the `WHERE` clause. That's why @aslakknutsen and I agreed to create a search endpoint under `/api/spaces/<SPACE-UUID>/search` in order to automatically add the space ID to the query condition. This will be implemented in another PR and is tracked in openshiftio/openshift.io#4124
    
See fabric8-services/fabric8-wit#2210.
  • Loading branch information
kwk authored and aslakknutsen committed Aug 7, 2018
1 parent 6094d19 commit 35e1b1b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dsaas-services/core.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
services:
- hash: 18d2d478363ef2b2f4917db8d532afed80af0c9d
- hash: 2661cf80beff4aad9233b4a728b37b35e6298bcb
name: fabric8-wit
path: /openshift/core.app.yaml
url: https://github.com/fabric8-services/fabric8-wit/
Expand Down

0 comments on commit 35e1b1b

Please sign in to comment.