Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

Toggle button should not call analytics scan API #4150

Open
yzainee-zz opened this issue Aug 9, 2018 · 5 comments
Open

Toggle button should not call analytics scan API #4150

yzainee-zz opened this issue Aug 9, 2018 · 5 comments

Comments

@yzainee-zz
Copy link

Currently when the toggle button ( cve_notification) is enabled in the UI, it triggers an API call to the analytics scan. The toggling of the button should not call any scan. The scan is supposed to be called only from the build flow.

Refer to this conversation for more details: https://chat.openshift.io/developers/pl/47c71f8eoirc9ngaz6tmbesk8c.

@nurali-techie
Copy link
Collaborator

@yzainee is it SEV2? What I understand is it's making extra call which need to be stopped. It's not blocking any user for using functionality.

@nurali-techie nurali-techie removed their assignment Aug 13, 2018
@miteshvp
Copy link

@nurali-techie - do you see any challenges in blocking that extra call?

@yzainee-zz
Copy link
Author

@aslakknutsen Closing this issue as we will be handling this issue in our backend. @miteshvp This will be lots of changes in the platform side, lets handle it in our code.

@aslakknutsen
Copy link
Collaborator

remove everything around the gemini service from wit https://github.com/fabric8-services/fabric8-wit/tree/master/codebase/analytics-gemini and everything around it. Just store the CVEScan bool on Codebase as a bool and nothing more.

@nurali-techie
Copy link
Collaborator

PR is merged but changes will NOT apply to prod-preview until this is fixed https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/2349

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants