-
Notifications
You must be signed in to change notification settings - Fork 66
Toggle button should not call analytics scan API #4150
Comments
@yzainee is it SEV2? What I understand is it's making extra call which need to be stopped. It's not blocking any user for using functionality. |
@nurali-techie - do you see any challenges in blocking that extra call? |
@aslakknutsen Closing this issue as we will be handling this issue in our backend. @miteshvp This will be lots of changes in the platform side, lets handle it in our code. |
remove everything around the gemini service from wit https://github.com/fabric8-services/fabric8-wit/tree/master/codebase/analytics-gemini and everything around it. Just store the CVEScan bool on Codebase as a bool and nothing more. |
- TEMPORARY fix for openshiftio/openshift.io#4150.
PR is merged but changes will NOT apply to prod-preview until this is fixed https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/2349 |
Currently when the toggle button ( cve_notification) is enabled in the UI, it triggers an API call to the analytics scan. The toggling of the button should not call any scan. The scan is supposed to be called only from the build flow.
Refer to this conversation for more details: https://chat.openshift.io/developers/pl/47c71f8eoirc9ngaz6tmbesk8c.
The text was updated successfully, but these errors were encountered: