Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

Clean up Che Workspaces #388

Open
burrsutter opened this issue Jul 22, 2017 · 31 comments
Open

Clean up Che Workspaces #388

burrsutter opened this issue Jul 22, 2017 · 31 comments

Comments

@burrsutter
Copy link

The number of workspaces tends to grow over time.
https://screencast.com/t/gMfOy9zCrae

Besides the screen above, what is the technique for removing workspaces you no longer need?

Are there other places to go clean up?

@ldimaggi
Copy link
Collaborator

ldimaggi commented Jul 22, 2017 via email

@burrsutter
Copy link
Author

The script says "TODO"

Step 4 - Delete Che workspaces - TODO

workspaces=curl -L --header 'Authorization: Bearer $5' http://che-osiotest3141-che.8a09.starter-us-east-2.openshiftapps.com/api/workspace | grep -oP '"che","id":"[\w-]+' | sed 's/"che","id":"//g'

for workspace in $WORKSPACES;
do echo "deleting workspace " $workspace ;
curl -vLX DELETE -H 'Authorization: Bearer $5' https://che-osiotest3141-che.8a09.starter-us-east-2.openshiftapps.com/api/workspace/$workspace;
done

@ldimaggi
Copy link
Collaborator

ldimaggi commented Jul 24, 2017 via email

@l0rd
Copy link
Collaborator

l0rd commented Jul 25, 2017

In theory you should be able to delete a workspace from the codebases page:
image

But that's not available and that's why we haven't removed Che dashboard in osio yet.

@l0rd
Copy link
Collaborator

l0rd commented Jul 25, 2017

c.f. fabric8-ui/fabric8-ui#1528

@joshuawilson
Copy link
Member

@l0rd who is working on adding support for deleting a workspace? To be clear that is not the same as "remove codebase".

@gorkem
Copy link
Collaborator

gorkem commented Jul 25, 2017

@joshuawilson I think this is a very good time to introduce @ashumilova. Her team does the Dashboard for Che and they will be porting some of that functionality to OSIO. @ashumilova Would you like to take a look at this one, it is a small enough thing to get you familiar with the codebase. @ibuziuk and @l0rd can show the APIs to be used etc.

@joshuawilson
Copy link
Member

sounds like a great place for her and her team to start

@ibuziuk
Copy link
Collaborator

ibuziuk commented Jul 25, 2017

@gorkem che-starter already has endpoints for workspace deletion[1]. So for me it looks like we need to:

  • expose delete endpoint from fabric8-wit that will call che-starter API
  • add "Delete Workspace" button to UI that wil call fabric8-wit delete endpoint

Sounds like a plan ?

[1] http://che-starter-dsaas-preview.b6ff.rh-idev.openshiftapps.com/swagger-ui.html#!/workspace-controller/deleteExistingWorkspaceUsingDELETE

@joshuawilson
Copy link
Member

That works for me.

@ashumilova
Copy link
Collaborator

Hi, yes - we could start getting familiar with codebase with this one.

@l0rd
Copy link
Collaborator

l0rd commented Jul 26, 2017

Thanks @ashumilova. @joshuawilson I think that "Remove codebase" button should delete the related Che workspaces too. Now that button seems disabled but if there is some code behind that or if someone is working to implement it we may need to update the remove codebase too.

@joshuawilson
Copy link
Member

Right now that button is a place holder. It is intended to delete the repo on Github. I do NOT think it should do more then that. That is a crazy, scary option. It should do only that.

@joshuawilson joshuawilson modified the milestone: Workshop Blockers Jul 31, 2017
@bmicklea
Copy link
Collaborator

My two cents:

  • "Remove Codebase" should be at the bottom of the list and there should be a popup explaining what it will do and ask user to confirm.
  • "Delete Che Workspace" should be at the top of the list and should do the same thing as deleting the workspace in the Che user dashboard.

@joshuawilson
Copy link
Member

@ibuziuk did you ever implement the api for deleting a workspace?
@aslakknutsen do we have an api to remove the codebase from the space, not from github?

@joshuawilson
Copy link
Member

@catrobson do we have designs for the codebases page, I can't find them? Do they take into consideration the changes that @bmicklea suggested.

@ibuziuk
Copy link
Collaborator

ibuziuk commented Sep 13, 2017

@joshuawilson
Copy link
Member

Great! Thanks @ibuziuk!

@ashumilova is this enough for you to start with? Let me know if you are missing something or get stuck.

@catrobson
Copy link
Collaborator

We're still going through design reviews, but here's the screens that we currently have for codebases and workspaces:
https://redhat.invisionapp.com/share/U2D95C1EC

The new designs probably do change the story for this.

@joshuawilson
Copy link
Member

We may want to fix it so that we can remove workspaces and then fill in the new UI as time allows.

@catrobson
Copy link
Collaborator

@joshuawilson +1 to do an incremental fix to remove workspaces before we move over to the new UI

@ibuziuk
Copy link
Collaborator

ibuziuk commented Sep 13, 2017

@joshuawilson this API is available on from che-starter side though, wit does not have endpoint for it AFAIK

@aslakknutsen
Copy link
Collaborator

@joshuawilson @ibuziuk It's easy enough to expose DELETE on the wit side and proxy it as we do with the others.

@joshuawilson
Copy link
Member

@michaelkleinhenz can we get one of your devs to do this please?

@gorkem
Copy link
Collaborator

gorkem commented Sep 14, 2017

@aslakknutsen probably easy but what is the long term goal? proxy all che workspace mgmt calls through wit? I am not sure about the value of doing that after the multi-tenant Che.

@michaelkleinhenz
Copy link
Collaborator

@joshuawilson Please create a story on the Planner backlog for it.

@joshuawilson
Copy link
Member

@gorkem and @aslakknutsen what do you want to do?

@michaelkleinhenz Isn't the Planner backlog for planner issues/user-stories?

@michaelkleinhenz
Copy link
Collaborator

Is there a story already that can be estimated and planned?

@joshuawilson
Copy link
Member

@michaelkleinhenz there is no story only this issue. Do think @xcoulon has time to help on this?

@qodfathr
Copy link
Collaborator

@slemeur @joshuawilson since #1549 is closed, can we close this? Or is #1016 blocking this? (I don't think it is but want to confirm with you.)

@joshuawilson
Copy link
Member

@ibuziuk what is the status on this? Do you still need the API or something else?

@joshuawilson joshuawilson removed their assignment Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests