-
Notifications
You must be signed in to change notification settings - Fork 66
Opening but not completing a codebase import or creation disrupts page displays #2732
Comments
Looking into this a bit deeper, there's a couple of things that may play a role in this:
Once this state is triggered, visiting other parts of openshift.io will cause multiple page elements to be combined into the same page, in a similar manner to #1975 [2] [1] https://github.com/fabric8-ui/fabric8-ui/blob/0db1b8c07de4bbc667826f2c6c309e1ca243e0d9/src/app/space/analyze/analyze-overview/analyze-overview.component.ts#L34 |
@aptmac could we fix the issue by adding in the template |
fixes with fabric8-ui/fabric8-ui#2730 |
Description: Opening and not completing a codebase addition/import can result in unintended page layouts (overlapping components and black screens).
Gif:
Steps to reproduce:
Go to a space, and click the "Add Codebase" button to open the wizard. Exit the wizard (by closing the x, the no thanks button, or clicking off of the modal)
Go to your profile page, notice that the spaces widget now shows the "Create Space" screen and a list of the user's spaces overlapped on top of each other.
This is the trace when running locally, running in production doesn't seem to print the errors. The trace says the error is here: https://github.com/fabric8-ui/fabric8-ui/blob/0db1b8c07de4bbc667826f2c6c309e1ca243e0d9/src/app/space/analyze/analyze-overview/analyze-overview.component.html#L37 [0], and it doesn't like the [spaces]="space.attributes.name" because it's null.
If you go back to your space and try to "Add Codebase" again, the page goes completely black.
[0] https://github.com/fabric8-ui/fabric8-ui/blob/0db1b8c07de4bbc667826f2c6c309e1ca243e0d9/src/app/space/analyze/analyze-overview/analyze-overview.component.html#L37
The text was updated successfully, but these errors were encountered: