Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

Some input fields must have restrictions for added text #2649

Open
SkorikSergey opened this issue Mar 16, 2018 · 6 comments
Open

Some input fields must have restrictions for added text #2649

SkorikSergey opened this issue Mar 16, 2018 · 6 comments

Comments

@SkorikSergey
Copy link

SkorikSergey commented Mar 16, 2018

Steps to reproduce:
Add a very long text to a space description or work items comments.

Actual result:
Added text can be saved.

Screencast:
screencast-openshift io-2018 10 10-16-06-03

@joshuawilson
Copy link
Member

@catrobson how do you want to handle this?

@catrobson
Copy link
Collaborator

We saw this problem when we went to implement the new dashboard and fixed it in that version. I'd say lets wait for this new design to come through to fix this since its a very short horizon to that.

@stevengutz stevengutz added the priority/P4 Normal label Aug 2, 2018
@aptmac
Copy link
Collaborator

aptmac commented Aug 20, 2018

The new dashboard handles this by truncating the text and hiding it [0], however this still happens with the old dashboard (production/beta).

[0] https://github.com/fabric8-ui/fabric8-ui/blob/master/src/app/dashboard-widgets/edit-space-description-widget/edit-space-description-widget.component.less#L92

aptmac added a commit to aptmac/fabric8-ui that referenced this issue Aug 20, 2018
@muruGanesan
Copy link
Collaborator

@SkorikSergey,
The screenshot provided looks very old.
Could please review the latest implementation and provide your observation?
We (UXD) team is fixing some of these inconsistency issues with a new story #4191. Please review those designs too.

CC: @aptmac, @joshuawilson

@aptmac
Copy link
Collaborator

aptmac commented Oct 10, 2018

This is still relevant; the amount of text you can cram into the description is more than what can be shown.

Edit:

For example, I have a space with a long name and long description.

Production/Beta:
2018-10-10-095416_1559x831_scrot

Experimental:
2018-10-10-095433_1521x100_scrot

Gif (look at how much I can scroll!):
ezgif-1-10ccdf547456

@muruGanesan
Copy link
Collaborator

@aptmac,
Thanks for providing your input and screenshot.
We will look into it and address with an appropriate resolution.

CC: @catrobson, @serenamarie125, @sunilmalagi , @AshishDurgude

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants