-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OCP-21034 #2716
Fix OCP-21034 #2716
Conversation
@@ -50,4 +50,4 @@ check_name_validation_error: | |||
- selector: | |||
xpath: //h4[contains(.,'error occur')] | |||
- selector: | |||
xpath: //div[contains(.,'subdomain must consist of lower case alphanumeric character')] | |||
xpath: //div[contains(text(),'subdomain must consist of lower case alphanumeric character')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help explain The error message will disappear on page when too many results found on fuzzy query
? I didn't get your point
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yapei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@XiyunZhao: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The error message will disappear on page when too many results found on fuzzy query, that's the reason why the case failed. So this changes is to make sure only one result can be found