Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OCP-21034 #2716

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Fix OCP-21034 #2716

merged 1 commit into from
Mar 3, 2022

Conversation

XiyunZhao
Copy link
Contributor

The error message will disappear on page when too many results found on fuzzy query, that's the reason why the case failed. So this changes is to make sure only one result can be found

@openshift-ci openshift-ci bot requested review from yanpzhan and yapei March 2, 2022 09:31
@@ -50,4 +50,4 @@ check_name_validation_error:
- selector:
xpath: //h4[contains(.,'error occur')]
- selector:
xpath: //div[contains(.,'subdomain must consist of lower case alphanumeric character')]
xpath: //div[contains(text(),'subdomain must consist of lower case alphanumeric character')]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help explain The error message will disappear on page when too many results found on fuzzy query ? I didn't get your point

@yapei
Copy link
Contributor

yapei commented Mar 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@yapei
Copy link
Contributor

yapei commented Mar 3, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2022

@XiyunZhao: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 50315aa into openshift:master Mar 3, 2022
@XiyunZhao XiyunZhao deleted the fix47 branch March 8, 2022 01:37
sunzhaohua2 pushed a commit to sunzhaohua2/verification-tests that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants