Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env vars for logging to set catsrc and channel #1870

Merged
merged 1 commit into from
Mar 1, 2021
Merged

add env vars for logging to set catsrc and channel #1870

merged 1 commit into from
Mar 1, 2021

Conversation

QiaolingTang
Copy link
Contributor

Start from logging 5.0, there have several different channels, to testing different channels, it's hard to determine the channel name in scenarios. To match logging testing requirements, adding two env vars logging_catsrc and logging_channel_name.

An example about how to set them:

export BUSHSLICER_CONFIG='
  global:
    browser: chrome
  environments:
    ocp4:
      admin_creds_spec: "https://example.com/auth/kubeconfig/*view*/"
      version: "4.8"
      logging_catsrc: "example-registry"
      logging_channel_name: "5.0"
      idp: "example-idp"
      admin_console_url: "https://console-openshift-console.apps.example.com"
'

/cc @anpingli

Copy link
Contributor

@anpingli anpingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QiaolingTang /lgtm. @liangxia Could you review it?
BTW, for long perspective, we will have different catalog source name and channel name to different operators. Let's start think about this and consider to implement this in future.

@QiaolingTang
Copy link
Contributor Author

/assign @liangxia @pruan-rht

@liangxia
Copy link
Member

liangxia commented Mar 1, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangxia, QiaolingTang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit f8641cd into openshift:master Mar 1, 2021
@QiaolingTang QiaolingTang deleted the add_logging_env branch March 1, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants