-
Notifications
You must be signed in to change notification settings - Fork 55
Update module github.com/onsi/ginkgo/v2 to v2.23.4 #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update module github.com/onsi/ginkgo/v2 to v2.23.4 #325
Conversation
ℹ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: red-hat-konflux[bot], wshearn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0a6c365
to
ae5bf96
Compare
New changes are detected. LGTM label has been removed. |
0a4da38
to
fa2783d
Compare
fa2783d
to
37ea07a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 72.75% 72.75%
=======================================
Files 11 11
Lines 701 701
=======================================
Hits 510 510
Misses 170 170
Partials 21 21 🚀 New features to boost your workflow:
|
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
37ea07a
to
da739c1
Compare
@red-hat-konflux[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v2.9.5
->v2.23.4
Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
onsi/ginkgo (github.com/onsi/ginkgo/v2)
v2.23.4
Compare Source
2.23.4
Prior to this release Ginkgo would compute the incorrect number of available CPUs when running with
-p
in a linux container. Thanks to @emirot for the fix!Features
2b9c428
]Fixes
1f59d07
]Maintenance
2d134d5
]v2.23.3
Compare Source
2.23.3
Fixes
-
as a standalone argument [cfcc1a5
]feaf292
]88e2282
]v2.23.2
Compare Source
2.23.2
🎉🎉🎉
At long last, some long-standing performance gaps between
ginkgo
andgo test
have been resolved!Ginkgo operates by running
go test -c
to generate test binaries, and then running those binaries. It turns out that the compilation step ofgo test -c
is slower thango test
's compilation step becausego test
strips out debug symbols (ldflags=-w
) whereasgo test -c
does not.Ginkgo now passes the appropriate
ldflags
togo test -c
when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and whenginkgo build
is called explicitly.This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.
v2.23.1
Compare Source
2.23.1
🚨 For users on MacOS 🚨
A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.
Fixes
Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:
a0e52ff
]b799d8d
]This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.
v2.23.0
Compare Source
2.23.0
Ginkgo 2.23.0 adds a handful of methods to
GinkgoT()
to make it compatible with thetesting.TB
interface in Go 1.24.GinkgoT().Context()
, in particular, is a useful shorthand for generating a new context that will clean itself up in aDeferCleanup()
. This has subtle behavior differences from the golang implementation but should make sense in a Ginkgo... um... context.Features
37a511b
]Fixes
7556a86
]4df06c6
]Maintenance
cbcf39a
]9b261ff
]00f19c8
]e98a4df
]60cc4e2
]fea6f2d
]31d7813
]fc3bbd6
]aee0d56
]809a710
]v2.22.2
Compare Source
What's Changed
Full Changelog: onsi/ginkgo@v2.22.1...v2.22.2
v2.22.1
Compare Source
2.22.1
Fixes
Fix CSV encoding
aab3da6
]c09df39
]96a80fc
]43dad69
]Maintenance
c88c634
]4df44bf
]v2.22.0
Compare Source
2.22.0
Features
0fcaa08
]This allows serial tests to be filtered using the
label-filter
Maintenance
Various doc fixes
v2.21.0
Compare Source
2.21.0
Features
a69eb39
]bcab9c8
]Fixes
e548367
]SpecsThatWillBeRun
withSpecsThatWillRun
[
c2c4d3c
]Maintenance
7e65a00
]v2.20.2
Compare Source
2.20.2
Require Go 1.22+
Maintenance
a671816
]v2.20.1
Compare Source
2.20.1
Fixes
d6f9640
]v2.20.0
Compare Source
2.20.0
Features
be5ab95
]Maintenance
d303d14
]7a50221
]v2.19.1
Compare Source
2.19.1
Fixes
63c8c30
]ff41e27
]Maintenance
76f4e0c
]b69c00d
]f097741
]v2.19.0
Compare Source
2.19.0
Features
Label Sets allow for more expressive and flexible label filtering.
v2.18.0
Compare Source
2.18.0
Features
f010b65
]d80eebe
]Fixes
42013d6
]Maintenance
fcf1fd7
]8bb14fd
]04bfad7
]v2.17.3
Compare Source
2.17.3
Fixes
ginkgo watch
now ignores hidden files [bde6e00
]v2.17.2
Compare Source
2.17.2
Fixes
32259c8
]780e7a3
]Maintenance
d91fe4e
]8cb662e
]3134422
]eca81b4
]760def8
]4ce33f4
]f2fcd97
]fd622d2
]5474a26
]e6d1170
]7f447b2
]f15239a
]v2.17.1
Compare Source
2.17.1
Fixes
af0330d
]v2.17.0
Compare Source
2.17.0
Features
--github-output
for nicer output in github actions [e8a2056
]Maintenance
977bc6f
]e297e7b
]v2.16.0
Compare Source
2.16.0
Features
Fixes
23f0cc5
]cd418b7
]Maintenance
2cebe8d
]06de431
]898cba9
]17ae120
]5a179ed
]a1e6b69
]d52951d
]4471b2e
]v2.15.0
Compare Source
2.15.0
Features
8f3bd70
]96e915c
]Fixes
c245d09
]dca77c8
]dbaf18f
]6f67a14
]Maintenance
4fcd0b3
]v2.14.0
Compare Source
2.14.0
Features
You can now use
GinkgoTB()
when you need an instance oftesting.TB
to pass to a library.Prior to this release table testing only supported generating individual
It
s for each test entry.DescribeTableSubtree
extends table testing support to entire testing subtrees - under the hoodDescrieTableSubtree
generates a new container for each entry and invokes your function to fill our the container. See the docs to learn more.65ec56d
]4a2c832
]92b6744
]Fixes
beb9507
]4ac3a13
]b2e5bc5
]Maintenance
465a8ec
]eab0e40
]fbf9724
]3ee80ee
]123e1d5
]558f6e0
]84ff7f3
]v2.13.2
Compare Source
2.13.2
Fixes
e2e81c8
](*regexp.Regexp).MatchString
(#1302) [3b2a2a7
]v2.13.1
Compare Source
2.13.1
Fixes
1296 fix(precompiled test guite): exec bit check omitted on Windows (#1301) [
26eea01
]Maintenance
7161a9d
]7fc7b10
]74bbd65
]9373633
]6e3cf65
]v2.13.0
Compare Source
2.13.0
Features
Add PreviewSpect() to enable programmatic preview access to the suite report (fixes #1225)
v2.12.1
Compare Source
2.12.1
Fixes
90d4846
]Maintenance
555f543
]d867b7d
]v2.12.0
Compare Source
2.12.0
Features
05de518
]Fixes
27c2f5d
]Maintenance
Various chores/dependency bumps.
v2.11.0
Compare Source
2.11.0
In prior versions of Ginkgo specs the CLI filter flags (e.g.
--focus
,--label-filter
) would override any programmatic focus. This behavior has proved surprising and confusing in at least the following ways:Going forward Ginkgo will AND all programmatic and CLI filters. Moreover, the presence of any programmatic focused tests will always result in a non-zero exit code.
This change is technically a change in Ginkgo's external contract and may require some users to make changes to successfully adopt. Specifically: it's possible some users were intentionally using CLI filters to override programmatic focus. If this is you please open an issue so we can explore solutions to the underlying problem you are trying to solve.
Fixes
d6bba86
]Maintenance
4a70a38
]97eda4d
]v2.10.0
Compare Source
2.10.0
Features
a782a77
]adds a new --tags flag to ginkgo generate
Fixes
548d78e
]Maintenance
2b76a5e
]v2.9.7
Compare Source
2.9.7
Fixes
07fc3a0
]v2.9.6
Compare Source
2.9.6
Fixes
0ac65de
]Maintenance
3e39231
]Configuration
📅 Schedule: Branch creation - "after 5am on sunday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test
.This PR has been generated by MintMaker (powered by Renovate Bot).