Skip to content

Update module github.com/onsi/ginkgo/v2 to v2.23.4 #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

red-hat-konflux[bot]
Copy link
Contributor

@red-hat-konflux red-hat-konflux bot commented Mar 2, 2025

This PR contains the following updates:

Package Change Age Confidence
github.com/onsi/ginkgo/v2 v2.9.5 -> v2.23.4 age confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

onsi/ginkgo (github.com/onsi/ginkgo/v2)

v2.23.4

Compare Source

2.23.4

Prior to this release Ginkgo would compute the incorrect number of available CPUs when running with -p in a linux container. Thanks to @​emirot for the fix!

Features
  • Add automaxprocs for using CPUQuota [2b9c428]
Fixes
  • clarify gotchas about -vet flag [1f59d07]
Maintenance

v2.23.3

Compare Source

2.23.3

Fixes
  • allow - as a standalone argument [cfcc1a5]
  • Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context() [feaf292]
  • ignore exit code for symbol test on linux [88e2282]

v2.23.2

Compare Source

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

v2.23.1

Compare Source

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

  • make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]
  • emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.

v2.23.0

Compare Source

2.23.0

Ginkgo 2.23.0 adds a handful of methods to GinkgoT() to make it compatible with the testing.TB interface in Go 1.24. GinkgoT().Context(), in particular, is a useful shorthand for generating a new context that will clean itself up in a DeferCleanup(). This has subtle behavior differences from the golang implementation but should make sense in a Ginkgo... um... context.

Features
  • bump to go 1.24.0 - support new testing.TB methods and add a test to cover testing.TB regressions [37a511b]
Fixes
  • fix edge case where build -o is pointing at an explicit file, not a directory [7556a86]
  • Fix binary paths when precompiling multiple suites. [4df06c6]
Maintenance

v2.22.2

Compare Source

What's Changed

Full Changelog: onsi/ginkgo@v2.22.1...v2.22.2

v2.22.1

Compare Source

2.22.1

Fixes

Fix CSV encoding

Maintenance
  • ensure *.test files are gitignored so we don't accidentally commit compiled tests again [c88c634]
  • remove golang.org/x/net/context in favour of stdlib context [4df44bf]

v2.22.0

Compare Source

2.22.0

Features
  • Add label to serial nodes [0fcaa08]

This allows serial tests to be filtered using the label-filter

Maintenance

Various doc fixes

v2.21.0

Compare Source

2.21.0

Features
  • add support for GINKGO_TIME_FORMAT [a69eb39]
  • add GINKGO_NO_COLOR to disable colors via environment variables [bcab9c8]
Fixes
  • increase threshold in timeline matcher [e548367]
  • Fix the document by replacing SpecsThatWillBeRun with SpecsThatWillRun
    [c2c4d3c]
Maintenance
  • bump various dependencies [7e65a00]

v2.20.2

Compare Source

2.20.2

Require Go 1.22+

Maintenance

v2.20.1

Compare Source

2.20.1

Fixes
  • make BeSpecEvent duration matcher more forgiving [d6f9640]

v2.20.0

Compare Source

2.20.0

Features
Maintenance
  • Add update-deps to makefile [d303d14]
  • bump all dependencies [7a50221]

v2.19.1

Compare Source

2.19.1

Fixes
  • update supported platforms for race conditions [63c8c30]
  • [build] Allow custom name for binaries. [ff41e27]
Maintenance

v2.19.0

Compare Source

2.19.0

Features

Label Sets allow for more expressive and flexible label filtering.

v2.18.0

Compare Source

2.18.0

Features
  • Add --slience-skips and --force-newlines [f010b65]
  • fail when no tests were run and --fail-on-empty was set [d80eebe]
Fixes
  • Fix table entry context edge case [42013d6]
Maintenance

v2.17.3

Compare Source

2.17.3

Fixes

ginkgo watch now ignores hidden files [bde6e00]

v2.17.2

Compare Source

2.17.2

Fixes
  • fix: close files [32259c8]
  • fix github output log level for skipped specs [780e7a3]
Maintenance

v2.17.1

Compare Source

2.17.1

Fixes
  • If the user sets --seed=0, make sure all parallel nodes get the same seed [af0330d]

v2.17.0

Compare Source

2.17.0

Features
  • add --github-output for nicer output in github actions [e8a2056]
Maintenance

v2.16.0

Compare Source

2.16.0

Features
  • add SpecContext to reporting nodes
Fixes
Maintenance

v2.15.0

Compare Source

2.15.0

Features
  • JUnit reports now interpret Label(owner:X) and set owner to X. [8f3bd70]
  • include cancellation reason when cancelling spec context [96e915c]
Fixes
  • emit output of failed go tool cover invocation so users can try to debug things for themselves [c245d09]
  • fix outline when using nodot in ginkgo v2 [dca77c8]
  • Document areas where GinkgoT() behaves differently from testing.T [dbaf18f]
  • bugfix(docs): use Unsetenv instead of Clearenv (#​1337) [6f67a14]
Maintenance

v2.14.0

Compare Source

2.14.0

Features

You can now use GinkgoTB() when you need an instance of testing.TB to pass to a library.

Prior to this release table testing only supported generating individual Its for each test entry. DescribeTableSubtree extends table testing support to entire testing subtrees - under the hood DescrieTableSubtree generates a new container for each entry and invokes your function to fill our the container. See the docs to learn more.

Fixes
Maintenance

v2.13.2

Compare Source

2.13.2

Fixes

v2.13.1

Compare Source

2.13.1

Fixes
  • 1296 fix(precompiled test guite): exec bit check omitted on Windows (#​1301) [26eea01]

Maintenance

v2.13.0

Compare Source

2.13.0

Features

Add PreviewSpect() to enable programmatic preview access to the suite report (fixes #​1225)

v2.12.1

Compare Source

2.12.1

Fixes
Maintenance

v2.12.0

Compare Source

2.12.0

Features
  • feat: allow MustPassRepeatedly decorator to be set at suite level (#​1266) [05de518]
Fixes
Maintenance

Various chores/dependency bumps.

v2.11.0

Compare Source

2.11.0

In prior versions of Ginkgo specs the CLI filter flags (e.g. --focus, --label-filter) would override any programmatic focus. This behavior has proved surprising and confusing in at least the following ways:

  • users cannot combine programmatic filters and CLI filters to more efficiently select subsets of tests
  • CLI filters can override programmatic focus on CI systems resulting in an exit code of 0 despite the presence of (incorrectly!) committed focused specs.

Going forward Ginkgo will AND all programmatic and CLI filters. Moreover, the presence of any programmatic focused tests will always result in a non-zero exit code.

This change is technically a change in Ginkgo's external contract and may require some users to make changes to successfully adopt. Specifically: it's possible some users were intentionally using CLI filters to override programmatic focus. If this is you please open an issue so we can explore solutions to the underlying problem you are trying to solve.

Fixes
  • Programmatic focus is no longer overwrriten by CLI filters [d6bba86]
Maintenance

v2.10.0

Compare Source

2.10.0

Features
  • feat(ginkgo/generators): add --tags flag (#​1216) [a782a77]
    adds a new --tags flag to ginkgo generate
Fixes
Maintenance

v2.9.7

Compare Source

2.9.7

Fixes
  • fix race when multiple defercleanups are called in goroutines [07fc3a0]

v2.9.6

Compare Source

2.9.6

Fixes
Maintenance

Configuration

📅 Schedule: Branch creation - "after 5am on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

This PR has been generated by MintMaker (powered by Renovate Bot).

Copy link
Contributor Author

red-hat-konflux bot commented Mar 2, 2025

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 10 additional dependencies were updated

Details:

Package Change
github.com/onsi/gomega v1.27.7 -> v1.36.3
github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1 -> v0.0.0-20250403155104-27863c87afa6
golang.org/x/sys v0.28.0 -> v0.32.0
golang.org/x/term v0.27.0 -> v0.30.0
golang.org/x/text v0.21.0 -> v0.23.0
golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d -> v0.31.0
github.com/go-logr/logr v1.2.4 -> v1.4.2
github.com/google/go-cmp v0.6.0 -> v0.7.0
golang.org/x/net v0.33.0 -> v0.37.0
google.golang.org/protobuf v1.33.0 -> v1.36.5

@openshift-ci openshift-ci bot requested review from afreiberger and dem4gus March 2, 2025 23:39
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 2, 2025
Copy link
Contributor

openshift-ci bot commented Mar 2, 2025

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wshearn
Copy link
Contributor

wshearn commented Mar 11, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2025
@wshearn
Copy link
Contributor

wshearn commented Mar 11, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
Copy link
Contributor

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: red-hat-konflux[bot], wshearn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2025
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-onsi-ginkgo-v2-2.x branch from 0a6c365 to ae5bf96 Compare March 30, 2025 19:01
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2025
Copy link
Contributor

openshift-ci bot commented Mar 30, 2025

New changes are detected. LGTM label has been removed.

@red-hat-konflux red-hat-konflux bot changed the title Update module github.com/onsi/ginkgo/v2 to v2.22.2 Update module github.com/onsi/ginkgo/v2 to v2.23.3 Mar 30, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2025
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-onsi-ginkgo-v2-2.x branch 2 times, most recently from 0a4da38 to fa2783d Compare April 6, 2025 23:05
@red-hat-konflux red-hat-konflux bot changed the title Update module github.com/onsi/ginkgo/v2 to v2.23.3 Update module github.com/onsi/ginkgo/v2 to v2.23.4 Apr 6, 2025
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-onsi-ginkgo-v2-2.x branch from fa2783d to 37ea07a Compare May 4, 2025 22:30
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.75%. Comparing base (418b201) to head (da739c1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   72.75%   72.75%           
=======================================
  Files          11       11           
  Lines         701      701           
=======================================
  Hits          510      510           
  Misses        170      170           
  Partials       21       21           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-onsi-ginkgo-v2-2.x branch from 37ea07a to da739c1 Compare June 29, 2025 08:15
Copy link
Contributor

openshift-ci bot commented Jun 29, 2025

@red-hat-konflux[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants