Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed --channel-group from --help options. #901

Conversation

olisakov
Copy link
Contributor

@olisakov olisakov commented Oct 23, 2022

@openshift-ci openshift-ci bot requested review from igoihman and vkareh October 23, 2022 13:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2022

Hi @olisakov. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2022
cmd/create/cluster/cmd.go Outdated Show resolved Hide resolved
@olisakov olisakov force-pushed the suppress-group-channel-from-cli branch from 2823017 to 9af97b0 Compare October 24, 2022 08:37
cmd/create/cluster/cmd.go Outdated Show resolved Hide resolved
@olisakov olisakov force-pushed the suppress-group-channel-from-cli branch from 9af97b0 to f34262b Compare October 24, 2022 08:48
@oriAdler
Copy link
Contributor

@olisakov why do we need openshift-client-linux.tar.gz in this PR?
Except for that LGTM.

@olisakov olisakov force-pushed the suppress-group-channel-from-cli branch from f34262b to ce65bcf Compare October 24, 2022 09:00
@oriAdler
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olisakov, oriAdler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

@olisakov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 510a8c7 into openshift:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants