Create cluster - validate subnets count interactively #776
Conversation
|
@vkareh @zgalor @ciaranRoche PTAL |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
oriAdler
force-pushed
the
create-cluster-validate-subnets-interactively
branch
from
4002a17 to
61c1801
Compare
Use the interactive validation to provide fast feedback to the user, to achieve a better user experience. Related: SDA-6331
oriAdler
force-pushed
the
create-cluster-validate-subnets-interactively
branch
from
61c1801 to
c16927a
Compare
| @@ -2100,37 +2106,6 @@ func validateExpiration() (expiration time.Time, err error) { | |||
| return | |||
| } | |||
|
|
|||
| const ( | |||
There was a problem hiding this comment.
I've just refactored lines 2103-2133 to pkg/aws/helpers.go to call the function in pkg/interactive/validation.go.
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oriAdler, zgalor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@oriAdler: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Use the interactive validation to provide fast feedback to the user,
to achieve a better user experience.
Related: SDA-6331
This PR follows up on #772
validate_subnet_interactive.webm