Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon STS flow #750

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Addon STS flow #750

merged 3 commits into from
Jun 30, 2022

Conversation

tbrisker
Copy link
Contributor

@tbrisker tbrisker commented Jun 20, 2022 •
edited by openshift-ci bot
Loading

Refs: SDA-5368

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tbrisker tbrisker changed the title Sts4 [WIP] Addon STS flow Jun 20, 2022
@openshift-ci openshift-ci bot requested review from ciaranRoche and zgalor June 20, 2022 09:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2022
@tbrisker tbrisker force-pushed the sts4 branch 2 times, most recently from baad955 to 31fb54a Compare June 22, 2022 15:27
@tbrisker tbrisker changed the title [WIP] Addon STS flow Addon STS flow Jun 22, 2022
@tbrisker tbrisker marked this pull request as ready for review June 22, 2022 15:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2022
@tbrisker
Copy link
Contributor Author

@vkareh cleaned this up a bit and split it into several commits for easier review

@openshift-ci openshift-ci bot requested a review from vkareh June 22, 2022 15:32
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2022
@vkareh
Copy link
Member

vkareh commented Jun 29, 2022

LGTM

@tbrisker can you fix the conflict and I'll stamp it for merge?

tbrisker added 2 commits June 30, 2022 14:16
@tbrisker
Refactor Role PolicyDoc creation
1535b67 
Adds support for both operator roles (with multiple service accounts)
and addon roles (with a single service account)
@tbrisker
Skip role version comparison for unversioned roles
1768419
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2022
vkareh
vkareh reviewed Jun 30, 2022
View reviewed changes
cmd/install/addon/cmd.go Outdated Show resolved Hide resolved
@tbrisker
Add basic STS addon installation flow
4826806 
Currently only supporting automatic aws role creation mode.
@vkareh
Copy link
Member

vkareh commented Jun 30, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

@tbrisker: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tbrisker, vkareh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tbrisker, vkareh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit d8e69bb into openshift:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkareh vkareh vkareh left review comments

@ciaranRoche ciaranRoche Awaiting requested review from ciaranRoche

@zgalor zgalor Awaiting requested review from zgalor

Assignees

@vkareh vkareh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbrisker @vkareh