Add helpers for creating a policy document and allowing actions #739
Conversation
openshift-ci
bot
added
the
approved
| @@ -33,7 +33,7 @@ type PolicyStatement struct { | |||
| // federated user to which you would like to allow or deny access. If you are creating an | |||
| // IAM permissions policy to attach to a user or role, you cannot include this element. | |||
| // The principal is implied as that user or role. | |||
| Principal PolicyStatementPrincipal `json:"Principal,omitempty"` | |||
| Principal *PolicyStatementPrincipal `json:"Principal,omitempty"` | |||
There was a problem hiding this comment.
This is needed so we don't include empty principals when serializing the document
|
|
||
| // IsActionAllowed checks if any of the statements in the document allows the wanted action. | ||
| // It does not take into account Resource or Principal constraints on the action. | ||
| func (p *PolicyDocument) IsActionAllowed(wanted string) bool { |
There was a problem hiding this comment.
Renamed to avoid confusion
|
@tbrisker: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tbrisker, vkareh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vkareh PTAL