-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-12538 | feat: Manual mode for create&delete operator-roles with hcp sharedvpc #2630
Conversation
d7dc3a1
to
d700f7b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2630 +/- ##
==========================================
+ Coverage 29.41% 29.48% +0.06%
==========================================
Files 180 180
Lines 24994 25031 +37
==========================================
+ Hits 7353 7380 +27
- Misses 17057 17066 +9
- Partials 584 585 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
d700f7b
to
bb20ad3
Compare
bb20ad3
to
8f8455f
Compare
@hunterkepley: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hunterkepley, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allows
--mode manual
for creating and deleting operator roles with the created&attached HCP SharedVPC policies.