OCM-9882 | feat: print custom worker disk size in describe nodepool #2426
Conversation
Signed-off-by: Will Kutler <wkutler@redhat.com>
|
/test coverage |
|
/lgtm |
|
/retest |
|
@willkutler: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2426 +/- ##
==========================================
+ Coverage 29.37% 29.39% +0.01%
==========================================
Files 161 161
Lines 22350 22355 +5
==========================================
+ Hits 6566 6571 +5
Misses 15239 15239
Partials 545 545 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidleerh, hunterkepley, willkutler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherrypick release_1.2.45 |
|
@davidleerh: new pull request created: #2428 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/OCM-9882
adds disk size to describe machinepool output for node pools if the disk size is returned from the API
note: this includes a check that the disk size is actually set because the API work for this still needs to be enabled. In the future we will be able to remove this check.